Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use an exact sha instead of a ref #93

Merged
merged 1 commit into from
Dec 5, 2024
Merged

use an exact sha instead of a ref #93

merged 1 commit into from
Dec 5, 2024

Conversation

GrantBirki
Copy link
Member

No description provided.

@GrantBirki GrantBirki requested a review from a team as a code owner December 5, 2024 06:33
Copy link

github-actions bot commented Dec 5, 2024

👋 Thanks for opening a pull request!

If you are new, please check out the deployment process to understand how to deploy this pull request. A trimmed down summary will be listed below:

  1. 🧪 Run a noop deployment with .noop as a comment on this PR

  2. 👀 Observe the CI and noop output on this pull request to ensure it is passing and doing what it is supposed to do

  3. ✔️ Obtain an approval/review on this pull request

  4. 🚀 Branch deploy your pull request to production with .deploy

    If anything goes wrong, rollback with .deploy main

  5. 🎉 Merge!

@GrantBirki
Copy link
Member Author

.noop

Copy link

github-actions bot commented Dec 5, 2024

Deployment Triggered 🚀

GrantBirki, started a noop deployment to production

You can watch the progress here 🔗

noop: sha-instead-of-ref

Copy link

github-actions bot commented Dec 5, 2024

Deployment Results ✅

GrantBirki successfully noop deployed branch sha-instead-of-ref to production

Show Results
Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply":

  # cloudflare_zone_settings_override.tarkov_dev has changed
  ~ resource "cloudflare_zone_settings_override" "tarkov_dev" {
        id                       = "a17204c79af55fcf05e4975f66e2490e"
        # (6 unchanged attributes hidden)

      ~ settings {
            # (51 unchanged attributes hidden)

          ~ minify {
              ~ css  = "on" -> "off"
              ~ html = "on" -> "off"
              ~ js   = "on" -> "off"
            }

            # (2 unchanged blocks hidden)
        }
    }

Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

─────────────────────────────────────────────────────────────────────────────

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # cloudflare_zone_settings_override.tarkov_dev will be updated in-place
  ~ resource "cloudflare_zone_settings_override" "tarkov_dev" {
        id                       = "a17204c79af55fcf05e4975f66e2490e"
        # (6 unchanged attributes hidden)

      ~ settings {
            # (51 unchanged attributes hidden)

          ~ minify {
              ~ css  = "off" -> "on"
              ~ html = "off" -> "on"
              ~ js   = "off" -> "on"
            }

            # (2 unchanged blocks hidden)
        }
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@GrantBirki
Copy link
Member Author

.deploy

Copy link

github-actions bot commented Dec 5, 2024

Deployment Triggered 🚀

GrantBirki, started a branch deployment to production

You can watch the progress here 🔗

Branch: sha-instead-of-ref

Copy link

github-actions bot commented Dec 5, 2024

Deployment Results ✅

GrantBirki successfully branch deployed branch sha-instead-of-ref to production

Show Results
Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply":

  # cloudflare_zone_settings_override.tarkov_dev has changed
  ~ resource "cloudflare_zone_settings_override" "tarkov_dev" {
        id                       = "a17204c79af55fcf05e4975f66e2490e"
        # (6 unchanged attributes hidden)

      ~ settings {
            # (51 unchanged attributes hidden)

          ~ minify {
              ~ css  = "on" -> "off"
              ~ html = "on" -> "off"
              ~ js   = "on" -> "off"
            }

            # (2 unchanged blocks hidden)
        }
    }

Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

─────────────────────────────────────────────────────────────────────────────

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # cloudflare_zone_settings_override.tarkov_dev will be updated in-place
  ~ resource "cloudflare_zone_settings_override" "tarkov_dev" {
        id                       = "a17204c79af55fcf05e4975f66e2490e"
        # (6 unchanged attributes hidden)

      ~ settings {
            # (51 unchanged attributes hidden)

          ~ minify {
              ~ css  = "off" -> "on"
              ~ html = "off" -> "on"
              ~ js   = "off" -> "on"
            }

            # (2 unchanged blocks hidden)
        }
    }

Plan: 0 to add, 1 to change, 0 to destroy.
cloudflare_zone_settings_override.tarkov_dev: Modifying... [id=a17204c79af55fcf05e4975f66e2490e]
cloudflare_zone_settings_override.tarkov_dev: Modifications complete after 3s [id=a17204c79af55fcf05e4975f66e2490e]

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

@GrantBirki GrantBirki merged commit 3f3aded into main Dec 5, 2024
2 checks passed
@GrantBirki GrantBirki deleted the sha-instead-of-ref branch December 5, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant