-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix automatic sort of Composite
items in fixed containers
#9
base: master
Are you sure you want to change the base?
Conversation
Hi @the-funnel You have 3 comments made by bots installed on this repo regarding this pull request. Check them below: There is 1 critical comment
There is 1 deploy comment
There is 1 info comment
|
Thanks for working on this @EricRibeiro! I'll take a look at it this weekend (hopefully). |
I'm also hitting this issue on a regular basis, it can be quite jarring on a long page – thanks for taking on the fix! |
import { sortBasedOnDOMPosition } from "./sortBasedOnDOMPosition"; | ||
import { Item } from "./types"; | ||
|
||
type SetItems = (items: Item[]) => void; | ||
|
||
function setItemsBasedOnDOMPosition(items: Item[], setItems: SetItems) { | ||
function mutateItemsBasedOnDOMPosition(items: Item[], setItems: SetItems) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reasoning behind the mutate
name?
Closes #8
How to test?
Does this PR introduce breaking changes?
No