Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix automatic sort of Composite items in fixed containers #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EricRibeiro
Copy link
Member

Closes #8

How to test?

Does this PR introduce breaking changes?

No

@EricRibeiro EricRibeiro requested a review from RonanFelipe April 17, 2021 23:45
@ghost ghost deleted a comment from codesandbox-ci bot Apr 17, 2021
@ghost
Copy link

ghost commented Apr 17, 2021

Hi @the-funnel

You have 3 comments made by bots installed on this repo regarding this pull request. Check them below:

There is 1 critical comment
There is 1 deploy comment
There is 1 info comment
  • 1 comment made by github-actions[bot]

    Size Change: +70 B (0%)

    Total Size: 257 kB

    Filename Size Change
    packages/reakit/dist/reakit.min.js 36 kB +70 B (0%)
    ℹ️ View Unchanged
    Filename Size Change
    packages/reakit-playground/dist/reakit-playground.min.js 187 kB 0 B
    packages/reakit-system-bootstrap/dist/reakit-system-bootstrap.min.js 19.1 kB 0 B
    packages/reakit-system-palette/dist/reakit-system-palette.min.js 8.85 kB 0 B
    packages/reakit-system/dist/reakit-system.min.js 2.45 kB 0 B
    packages/reakit-utils/dist/reakit-utils.min.js 3.46 kB 0 B

    compressed-size-action

@RonanFelipe
Copy link
Collaborator

Thanks for working on this @EricRibeiro! I'll take a look at it this weekend (hopefully).

@ghost ghost deleted a comment from github-actions bot Apr 17, 2021
@mairieli
Copy link
Collaborator

I'm also hitting this issue on a regular basis, it can be quite jarring on a long page – thanks for taking on the fix!

@ghost ghost deleted a comment from codecov bot Apr 17, 2021
import { sortBasedOnDOMPosition } from "./sortBasedOnDOMPosition";
import { Item } from "./types";

type SetItems = (items: Item[]) => void;

function setItemsBasedOnDOMPosition(items: Item[], setItems: SetItems) {
function mutateItemsBasedOnDOMPosition(items: Item[], setItems: SetItems) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reasoning behind the mutate name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composite automatic sort doesn't work on fixed containers
3 participants