From c6b435c4d50fe30897763edc73f792615a7f4edb Mon Sep 17 00:00:00 2001
From: Jordan Dominion <Cyberboss@users.noreply.github.com>
Date: Sat, 21 Oct 2023 03:46:36 -0400
Subject: [PATCH] More engine generic deployment chat messages

---
 .../Components/Chat/Providers/DiscordProvider.cs    |  9 +++++----
 .../Components/Chat/Providers/IrcProvider.cs        |  5 +++--
 .../Components/Chat/Providers/Provider.cs           | 13 +++++++++++++
 3 files changed, 21 insertions(+), 6 deletions(-)

diff --git a/src/Tgstation.Server.Host/Components/Chat/Providers/DiscordProvider.cs b/src/Tgstation.Server.Host/Components/Chat/Providers/DiscordProvider.cs
index 7737c33f3ac..a4be368ea22 100644
--- a/src/Tgstation.Server.Host/Components/Chat/Providers/DiscordProvider.cs
+++ b/src/Tgstation.Server.Host/Components/Chat/Providers/DiscordProvider.cs
@@ -322,9 +322,10 @@ public override async ValueTask<Func<string, string, ValueTask<Func<bool, ValueT
 			Logger.LogTrace("Attempting to post deploy embed to channel {channelId}...", channelId);
 			var channelsClient = serviceProvider.GetRequiredService<IDiscordRestChannelAPI>();
 
+			var prefix = GetEngineCompilerPrefix(engineVersion.Engine.Value);
 			var messageResponse = await channelsClient.CreateMessageAsync(
 				new Snowflake(channelId),
-				"DM: Deployment in progress...",
+				$"{prefix}: Deployment in progress...",
 				embeds: new List<IEmbed> { embed },
 				ct: cancellationToken);
 
@@ -371,7 +372,7 @@ public override async ValueTask<Func<string, string, ValueTask<Func<bool, ValueT
 					showDMOutput = showDMOutput && dreamMakerOutput.Length < MaxFieldValueLength - (6 + Environment.NewLine.Length);
 					if (showDMOutput)
 						fields.Add(new EmbedField(
-							"DreamMaker Output",
+							"Compiler Output",
 							$"```{Environment.NewLine}{dreamMakerOutput}{Environment.NewLine}```",
 							false));
 				}
@@ -382,7 +383,7 @@ public override async ValueTask<Func<string, string, ValueTask<Func<bool, ValueT
 						errorMessage,
 						false));
 
-				var updatedMessageText = errorMessage == null ? $"DM: Deployment pending reboot..." : $"DM: Deployment failed!";
+				var updatedMessageText = errorMessage == null ? $"{prefix}: Deployment pending reboot..." : $"{prefix}: Deployment failed!";
 
 				IMessage updatedMessage = null;
 				async ValueTask CreateUpdatedMessage()
@@ -432,7 +433,7 @@ async ValueTask CreateUpdatedMessage()
 					if (active)
 					{
 						completionString = "Succeeded";
-						updatedMessageText = $"DM: Deployment succeeded!";
+						updatedMessageText = $"{prefix}: Deployment succeeded!";
 						embed = CreateUpdatedEmbed(
 							"The deployment completed successfully and was applied to server.",
 							Color.Green);
diff --git a/src/Tgstation.Server.Host/Components/Chat/Providers/IrcProvider.cs b/src/Tgstation.Server.Host/Components/Chat/Providers/IrcProvider.cs
index b13c12f6e74..fae8002f5cf 100644
--- a/src/Tgstation.Server.Host/Components/Chat/Providers/IrcProvider.cs
+++ b/src/Tgstation.Server.Host/Components/Chat/Providers/IrcProvider.cs
@@ -262,13 +262,14 @@ public override async ValueTask<Func<string, string, ValueTask<Func<bool, ValueT
 								return result;
 							})));
 
+			var prefix = GetEngineCompilerPrefix(engineVersion.Engine.Value);
 			await SendMessage(
 				null,
 				new MessageContent
 				{
 					Text = String.Format(
 						CultureInfo.InvariantCulture,
-						"DM: Deploying revision: {0}{1}{2} BYOND Version: {3}{4}",
+						$"{prefix}: Deploying revision: {0}{1}{2} BYOND Version: {3}{4}",
 						commitInsert,
 						testmergeInsert,
 						remoteCommitInsert,
@@ -286,7 +287,7 @@ await SendMessage(
 					null,
 					new MessageContent
 					{
-						Text = $"DM: Deployment {(errorMessage == null ? "complete" : "failed")}!",
+						Text = $"{prefix}: Deployment {(errorMessage == null ? "complete" : "failed")}!",
 					},
 					channelId,
 					cancellationToken);
diff --git a/src/Tgstation.Server.Host/Components/Chat/Providers/Provider.cs b/src/Tgstation.Server.Host/Components/Chat/Providers/Provider.cs
index 29b93316a66..0dceac0dfba 100644
--- a/src/Tgstation.Server.Host/Components/Chat/Providers/Provider.cs
+++ b/src/Tgstation.Server.Host/Components/Chat/Providers/Provider.cs
@@ -70,6 +70,19 @@ abstract class Provider : IProvider
 		/// </summary>
 		CancellationTokenSource reconnectCts;
 
+		/// <summary>
+		/// Get the prefix for messages about deployments.
+		/// </summary>
+		/// <param name="engineType">The <see cref="Api.Models.EngineType"/> of the deployment.</param>
+		/// <returns>The <see cref="string"/> prefix.</returns>
+		protected static string GetEngineCompilerPrefix(Api.Models.EngineType engineType)
+			=> engineType switch
+			{
+				Api.Models.EngineType.Byond => "DM",
+				Api.Models.EngineType.OpenDream => "OD",
+				_ => throw new InvalidOperationException($"Unsupported engine type: {engineType}"),
+			};
+
 		/// <summary>
 		/// Initializes a new instance of the <see cref="Provider"/> class.
 		/// </summary>