Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not want to install react & react-dom dependency in node_modules #1335

Open
21duxue opened this issue Jun 7, 2024 · 1 comment
Open

Do not want to install react & react-dom dependency in node_modules #1335

21duxue opened this issue Jun 7, 2024 · 1 comment

Comments

@21duxue
Copy link

21duxue commented Jun 7, 2024 •
edited
Loading

My project is react introduced through external links。

Can I use it without installing react or react-dom?

If possible, how do I need to configure it? Thank you

jest + @testing-library/react

error

 FAIL  src/Header/index.test.js
  ● Test suite failed to run

    Cannot find module 'react' from '../../../node_modules/.pnpm/@[email protected]/node_modules/@testing-library/react/dist/act-compat.js'

    Require stack:
      /node_modules/.pnpm/@[email protected]/node_modules/@testing-library/react/dist/act-compat.js
      /node_modules/.pnpm/@[email protected]/node_modules/@testing-library/react/dist/index.js
      Header/index.test.js

      20 |   })
      21 |
    > 22 | import { screen, render } from "@testing-library/react"
         | ^

html

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
</head>
<body>
    <div id="root"></div>
</body>
    <script ignore src="/assets/react/16.14.0/production/react.js"></script>
    <script ignore src="/assets/react/16.14.0/production/react-dom.js"></script>
</html>

webpack

externals: {
      react: "React",
      "react-dom": "ReactDOM",
}
@MatanBobi
Copy link
Member

You can still install react and react-dom as dev dependencies, this is usually what people are doing in these kind of approaches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MatanBobi @21duxue