Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't run? (stripHeader undefined?) #8

Open
gsnedders opened this issue Mar 9, 2020 · 4 comments
Open

Doesn't run? (stripHeader undefined?) #8

gsnedders opened this issue Mar 9, 2020 · 4 comments

Comments

@gsnedders
Copy link

python test262.py --help
Traceback (most recent call last):
  File "test262.py", line 31, in <module>
    from parseTestRecord import parseTestRecord, stripHeader
ImportError: cannot import name stripHeader

stripHeader indeed seems to be undefined?

@gsnedders gsnedders changed the title Doesn't run? Doesn't run? (stripHeader undefined?) Mar 9, 2020
@gsnedders
Copy link
Author

Regression from #4, previously reported in comment there. cc/ @caitp @anba

@caitp
Copy link
Contributor

caitp commented Mar 9, 2020

I can’t really comment on this, as the only verification of the patch I did was using v8’s test runner, which didn’t hit the problem. The removal of that method was in the original version of this patch.

I guess the right fix is to update the stripHeader calls to the new thing, or else re-export it.

@jsjzgy
Copy link

jsjzgy commented Nov 6, 2020

I also encountered this problem, but I don’t know how to solve it, can anyone give a solution?

@cclauss
Copy link

cclauss commented Apr 15, 2023

stripHeader was removed in #4

Confirmed and reverted in #13 to fix failing pytests.

My hunch is that #4 also broke other tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants