Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration limitation with safety_margin and safety_margin_buffer #430

Open
Levi-Armstrong opened this issue Oct 26, 2024 · 6 comments
Open

Comments

@Levi-Armstrong
Copy link
Contributor

I recently ran into an failure issue using UR where the default collision config for trajopt sets the safety_margin=0.025 and the safety_margin_buffer=0.05 but there is one link pair on the UR which are always within 0.035. As a result this results with a lot of collision equation being added to the problem causing issues. This can be solved by reducing the safety margin_buffer to but that also can cause solver issues if it too small. Now trajopt supports setting individual link pair safety_margin data but not the safety_margin_buffer which needs to be added to provide necessary configuration. For now you can reduce the things such that the safety_margin + the safety_margin_buffer is less than the 0.035 but may not work for all cases.

@rjoomen
Copy link
Contributor

rjoomen commented Oct 26, 2024

Yes, I did wonder why it was not possible to set the buffer individually. Are you considering adding this?

@Levi-Armstrong
Copy link
Contributor Author

I think it should be added, but not sure when I would be able to get to it.

@rjoomen
Copy link
Contributor

rjoomen commented Oct 26, 2024

I'll take a quick look on Monday how much work this would be, but if it's not trivial, I don't think I have time to do it anytime soon, either.

@rjoomen
Copy link
Contributor

rjoomen commented Oct 28, 2024

I suppose the buffer should be added here, right? And remove this, as it will be part of info. (And all dependent code should be adapted to that, of course.)

@Levi-Armstrong
Copy link
Contributor Author

I suppose the buffer should be added here, right? And remove this, as it will be part of info. (And all dependent code should be adapted to that, of course.)

I believe your assessment is correct.

@Levi-Armstrong
Copy link
Contributor Author

Maybe a new struct instead of the array?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants