Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrete collision check setting #361

Open
rjoomen opened this issue Nov 20, 2023 · 3 comments
Open

Discrete collision check setting #361

rjoomen opened this issue Nov 20, 2023 · 3 comments

Comments

@rjoomen
Copy link
Contributor

rjoomen commented Nov 20, 2023

Shouldn't is_continuous be false here, as it is the LVSDiscreteCollisionEvaluator?

@rjoomen
Copy link
Contributor Author

rjoomen commented Nov 20, 2023

Otherwise LVSContinuousCollisionEvaluator::CalcCollisionData() and LVSDiscreteCollisionEvaluator::CalcCollisionData() are exactly the same.

@Levi-Armstrong
Copy link
Contributor

It needs to be set to true, it is still considered continues from a trajopt perspective even though it is using a discrete contact checker because it is integrating collision data along the path between two state.

@rjoomen
Copy link
Contributor Author

rjoomen commented Nov 21, 2023

What do you think about moving CalcCollisionData() to parent class ContinuousCollisionEvaluator then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants