Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weakref / transient #17

Open
simonseyock opened this issue Sep 3, 2023 · 1 comment
Open

weakref / transient #17

simonseyock opened this issue Sep 3, 2023 · 1 comment

Comments

@simonseyock
Copy link
Member

the class PackedCoordinateSequence uses a transient SoftReference. This might be tricky to convert correctly with WeakRef in typescript. It would be possible to provide an alternative implementation. That being said, the jsts implementation is missing this file altogether. @bjornharrtell do you know why that is the case? Is the PackedCoordinateSequence and PackedCoordinateSequenceFactory not needed in jsts?

Also I am a little confused why this line does not cause an error because the file does not exist:
https://github.com/bjornharrtell/jsts/blob/e18f6e86c4ba9f7cda3cbce39b0e590625982c43/src/org/locationtech/jts/geom/impl/PackedCoordinateSequenceFactory.js#L6

@bjornharrtell
Copy link

I think PackedCoordinateSequence is an opt in alternative memory model for coordinates that I never considered. It has like you suspect probably never been in working order and I think it is rarely used also upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants