Refactor provider config and test trust token/password #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MusicDin
force-pushed
the
fix/provider-config
branch
3 times, most recently
from
533981a to
c8590b6
Compare
MusicDin
force-pushed
the
fix/provider-config
branch
from
c8590b6 to
7bab8b5
Compare
MusicDin
force-pushed
the
fix/provider-config
branch
from
7bab8b5 to
8358c37
Compare
simondeziel
reviewed
Aug 30, 2024
simondeziel
reviewed
Aug 30, 2024
MusicDin
force-pushed
the
fix/provider-config
branch
from
8358c37 to
9657cd9
Compare
simondeziel
reviewed
Aug 30, 2024
MusicDin
force-pushed
the
fix/provider-config
branch
from
9657cd9 to
97a2664
Compare
simondeziel
reviewed
Aug 30, 2024
Signed-off-by: Din Music <[email protected]>
MusicDin
force-pushed
the
fix/provider-config
branch
from
8dacf7d to
10d0221
Compare
Signed-off-by: Din Music <[email protected]>
…for trust token/pass Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
MusicDin
force-pushed
the
fix/provider-config
branch
from
10d0221 to
e47669b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal is to make the provider config logic more intuitive and straight forward. This includes removal of the remote bootstraping during initial connection with the remote.
The majority of provider's initialization logic is also moved into
provider-config, which makes the provider block easier to test. Provider tests are also included in this PR.Finally, parsing of LXD remote address has been changed. Remote configuration will from now on accept only
addressattribute. The address value is expected to be a fully qualified LXD or Simplestreams address. The remote attributesportandscheme(and respective environment variables LXD_SCHEME and LXD_PORT) are now deprecated and provider will error out if set.