Schematics agent init #5
Conversation
SKIP UPGRADE TEST: init module
SKIP UPGRADE TEST: init module
SKIP UPGRADE TEST: init module
SKIP UPGRADE TEST: init module
SKIP UPGRADE TEST: init module
SKIP UPGRADE TEST: init module
SKIP UPGRADE TEST: init module
SKIP UPGRADE TEST: init module
SKIP UPGRADE TEST: init module
SKIP UPGRADE TEST: init module
SKIP UPGRADE TEST: init module
SKIP UPGRADE TEST: init module
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
| type = string | ||
| description = "The schematics agent version." | ||
| nullable = false | ||
| default = "1.0.1-beta" |
There was a problem hiding this comment.
why are we locking into a beta version? Also we need to figure out how we will manage this version. What are the current available versions and how often are they released? Should the module only support versions that we have tested yet?
There was a problem hiding this comment.
This needs to be updated as the ibm_schematics_agent is still in the beta. This is the only version which supports Kubernetes yet. I have been told that Openshift support will come soon in the upcoming version. Once that's out we can probably decide how to update this version.
| variable "agent_version" { | ||
| type = string | ||
| description = "The schematics agent version." | ||
| default = "1.0.1-beta" |
There was a problem hiding this comment.
By adding a default value here, its just one more place we need to maintain it. I guess we need to decide how we want to set the module up in terms of supporting versions, and if we do that we would want to pass the version in the tests. But lets first decide how we will handle versions as per my other comment
SKIP UPGRADE TEST: init module
|
/run pipeline |
SKIP UPGRADE TEST: init module
|
/run pipeline |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Creates Schematics Agent and deploys it on the existing cluster.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers