fix: various files

[surajsbharadwaj]

Description

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[AchimHaaser1]

solutions/ibm-catalog/sap-s4hana-bw4hana/main.tf
sap_tools_directory = "${var.software_download_directory # points to /software and does not exist on the monitoring host nor on the ansible host (only on the SAP hosts), VSI hosts only have /nfs

solutions/ibm-catalog/sap-s4hana-bw4hana/main.tf
requires a change: add '[ ]' around { sap_app_server ...} as Ansible monitoring is accepting a list only.
sap_app_server = jsonencode(
[ {
sap_app_server_nr = "01"
ip = module.sap_system.pi_netweaver_instance_management_ips
port = "5${var.sap_solution_vars.sap_swpm_pas_instance_nr}13"
}]
)

The validation of 'sap_monitorin_nr' is great,
let us think about the conversion to number. I think input '01' becomes '1', but Ansible needs a string '[01-99]

[AchimHaaser1]

coments only:
Monitoring is automatically activated in SAP-repo if schematics from VPC has a monitoring instance, shuld we leave to customer's choice?
cos-directory of x86_64, common expressions: x86_64 | amd64 | intel. x_86 is not known.
Renaming 'monitoring_config' to 'sap_monitoring_vars': 'sap_monitoring_vars' sound like values of SAP parameters,
but these values control the config of the monitoring configuration, just a matter of association.