Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add repo topics + remove usage_template from catalog manifest #531

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

ocofaigh
Copy link
Member

@ocofaigh ocofaigh commented Nov 2, 2023

Description

  • add repo topics
  • remove usage_template from catalog manifest. DAs are not designed to be embedded into part of another DA solution, they are designed to be the top level solution and not called from any higher level. So in this PR, I am removing the usage_template from the DA manifest which means the DA will no long show the Embed code section in the UI:
    image

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh
Copy link
Member Author

ocofaigh commented Nov 2, 2023

/run pipeline

@surajsbharadwaj surajsbharadwaj merged commit ba225b6 into main Nov 2, 2023
@surajsbharadwaj surajsbharadwaj deleted the topics branch November 2, 2023 14:50
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants