Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new rg id output #931

Merged
merged 8 commits into from
Dec 11, 2024
Merged

feat: add new rg id output #931

merged 8 commits into from
Dec 11, 2024

Conversation

jor2
Copy link
Member

@jor2 jor2 commented Dec 11, 2024

Description

add new rg output for workload cluster

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

add new resource group id output for workload cluster

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Dec 11, 2024
@jor2
Copy link
Member Author

jor2 commented Dec 11, 2024

/run pipeline

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also include an output for the name too

@jor2
Copy link
Member Author

jor2 commented Dec 11, 2024

/run pipeline

@jor2 jor2 requested a review from ocofaigh December 11, 2024 13:42
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per internal discussions, lets change the output to be more generic: workload_rg_id and workload_rg_name. You should be able to get the data from module.vpc_landing_zone.resource_group_data.

You should also add outputs for the management too incase we ever need it

@jor2 jor2 requested a review from ocofaigh December 11, 2024 15:51
@jor2
Copy link
Member Author

jor2 commented Dec 11, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Dec 11, 2024

/run pipeline

@ocofaigh ocofaigh merged commit ade1dd9 into main Dec 11, 2024
2 checks passed
@ocofaigh ocofaigh deleted the rg-output branch December 11, 2024 19:20
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 6.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants