New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage https://github.com/terraform-ibm-modules/terraform-ibm-security-group #410

Open

vburckhardt opened this issue Mar 31, 2023 · 0 comments · May be fixed by #422

Open

Leverage https://github.com/terraform-ibm-modules/terraform-ibm-security-group #410

vburckhardt opened this issue Mar 31, 2023 · 0 comments · May be fixed by #422

Assignees

Labels

enhancement internal-synced

Member

vburckhardt commented Mar 31, 2023

Description

What:

https://github.com/terraform-ibm-modules/terraform-ibm-security-group has been made available
The VSI module create security group with own logic at the moment

Goal:

Replace the security group logic in the module with calls to https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi/blob/main/security_group.tf .
Add the extra capability add_ibm_cloud_internal_rules to the module interface https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi/blob/main/variables.tf#L109
Use moved blocks if possible to avoid breaking change https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi/blob/main/security_group.tf (but this may not be fully possible - we should discuss if so)

vburckhardt added the enhancement label

mounika-nalla self-assigned this

vburckhardt linked a pull request

that will close this issue

feat: update security group logic #422

Open

9 tasks

terraform-ibm-modules-ops added the internal-synced label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment