Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:exposed visibility value for the provider in the DA #463

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

Aditya-ranjan-16
Copy link
Contributor

Description

exposed visibility value for the provider in the DA , with default value set to "private"

Git issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

exposes visibility value for the provider in the DA

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16 Aditya-ranjan-16 linked an issue Nov 21, 2024 that may be closed by this pull request
@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@shemau
Copy link
Contributor

shemau commented Nov 24, 2024

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please always explain why upgrade test was skipped. I see no reason why a change like this should need an upgrade test to be skipped.

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see upgrade test was skipped since provider_visibility is being added to the upgrade test and main branch doesn't have this yet. Risk is low, so I approve

@ocofaigh ocofaigh merged commit a6ed8cd into main Nov 26, 2024
2 checks passed
@ocofaigh ocofaigh deleted the provider_visibility branch November 26, 2024 10:57
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[terraform-ibm-icd-redis] Expose provider visibility in the DA
5 participants