Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support to store service credentials in sm #411

Merged
merged 20 commits into from
Dec 10, 2024
Merged

add support to store service credentials in sm #411

merged 20 commits into from
Dec 10, 2024

Conversation

Aayush-Abhyarthi
Copy link
Contributor

@Aayush-Abhyarthi Aayush-Abhyarthi commented Aug 27, 2024 •
edited
Loading

Description

#408

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

This enhancement will enable users to store service credentials in an existing secrets manager for Redis instance. Users can choose to use an existing secret group or create a new one for the service credentials.

Your notes help the merger write the commit message for the PR that is published in the release notes for the module. --->

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

shemau
shemau requested changes Aug 30, 2024
View reviewed changes
solutions/standard/DA-types.md Outdated Show resolved Hide resolved
solutions/standard/DA-types.md Outdated Show resolved Hide resolved
solutions/standard/DA-types.md Outdated Show resolved Hide resolved
@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

shemau
shemau requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are new inputs that lead to new resources being created, but there are no new outputs.

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

@shemau I made the changes here consistent with this PR(terraform-ibm-modules/terraform-ibm-event-notifications#266)

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

shemau
shemau requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are new variables in the DA, so I was expecting these to be exposed via /ibmcatalog.json

solutions/standard/main.tf Outdated Show resolved Hide resolved
solutions/standard/main.tf Outdated Show resolved Hide resolved
solutions/standard/main.tf Outdated Show resolved Hide resolved
solutions/standard/outputs.tf Outdated Show resolved Hide resolved
solutions/standard/outputs.tf Outdated Show resolved Hide resolved
solutions/standard/variables.tf Outdated Show resolved Hide resolved
tests/pr_test.go Show resolved Hide resolved
@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

@ocofaigh @shemau can I get a review on this please. PR is waiting for some time now. Wanted to get it done.

shemau
shemau approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It is still concerning that the DAs are diverging.

@ocofaigh ocofaigh merged commit c8d05e8 into main Dec 10, 2024
2 checks passed
@ocofaigh ocofaigh deleted the store-service-credentials branch December 10, 2024 16:47
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shemau shemau shemau approved these changes

@akocbek akocbek Awaiting requested review from akocbek akocbek is a code owner

@ocofaigh ocofaigh Awaiting requested review from ocofaigh

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Aayush-Abhyarthi @terraform-ibm-modules-ops @shemau @ocofaigh