Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): provider 1.70 required for CBR for SM in apps example #135

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

shemau
Copy link
Contributor

@shemau shemau commented Nov 27, 2024

Description

Secrets manager changes introduced in #125 will require IBM provider 1.70.0 for CBR for private cert. The apps example needs to bump to at least that version. The jobs example will need to validate the minimal level.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau shemau requested a review from akocbek as a code owner November 27, 2024 13:01
@shemau
Copy link
Contributor Author

shemau commented Nov 27, 2024

/run pipeline

@akocbek akocbek merged commit f243af1 into main Nov 27, 2024
2 checks passed
@akocbek akocbek deleted the cbr-170 branch November 27, 2024 14:57
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants