Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add web application firewall #410

Merged
merged 20 commits into from
Nov 29, 2023
Merged

feat: add web application firewall #410

merged 20 commits into from
Nov 29, 2023

Conversation

iamar7
Copy link
Member

@iamar7 iamar7 commented Oct 26, 2023 •
edited
Loading

Description

Add Web Application Firewall feature in CIS module.

https://github.ibm.com/GoldenEye/issues/issues/6218

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

This release only allows user to enable/disable the web application firewall(WAF) protection as domain settings with the default rules and we are not setting/updating any WAF rule.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@iamar7
Copy link
Member Author

iamar7 commented Oct 30, 2023

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Oct 30, 2023

/run pipeline

@iamar7 iamar7 marked this pull request as ready for review November 2, 2023 04:40
@iamar7 iamar7 changed the title [WIP] feat: add web application firewall feat: add web application firewall Nov 2, 2023
maheshwarishikha
maheshwarishikha requested changes Nov 2, 2023
View reviewed changes
Copy link
Member

@maheshwarishikha maheshwarishikha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, update release note appropriately. We are not setting/updating any WAF rule instead we are just enabling/disabling the WAF as domain setting with the default rules. Better to call-out this.

@iamar7
Copy link
Member Author

iamar7 commented Nov 2, 2023

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Nov 6, 2023

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Nov 7, 2023

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Nov 16, 2023

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Nov 17, 2023

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Nov 22, 2023

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Nov 23, 2023

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Nov 23, 2023

/run pipeline

vbontempi
vbontempi reviewed Nov 24, 2023
View reviewed changes
modules/waf/variables.tf Outdated Show resolved Hide resolved
@iamar7
Copy link
Member Author

iamar7 commented Nov 27, 2023

/run pipeline

vbontempi
vbontempi approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@vbontempi vbontempi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@ocofaigh ocofaigh merged commit d06d7a6 into main Nov 29, 2023
@ocofaigh ocofaigh deleted the 6218-waf branch November 29, 2023 09:49
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbontempi vbontempi vbontempi approved these changes

@maheshwarishikha maheshwarishikha maheshwarishikha approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iamar7 @terraform-ibm-modules-ops @maheshwarishikha @vbontempi @ocofaigh