-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: doc to access OCP endpoint via CIS #385
Conversation
/run pipeline |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the content that will form the solution tutorial?
If so, we probably don't need it here, but can just point to the public cloud docs tutorial when that's ready (from the main readme or an example readme).
If it's different content, can you help me understand the difference?
Its a different content. Here we are not talking about SLZ, it is just to close a loop to access any endpoint via CIS. We have taken example of OpenShift. SLZ tutorials will be quite different. |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @maheshwarishikha. Here are my suggestions to improve the task topic.
- Start with an H1 in every file, and use sequentially headings
- Break up the long series of steps with sections (and renumber).
- Provide and introduction, context to the sections, and a conclusion.
- Make sure that you have all the prereqs.
- Check for missing articles (
the
,a
). - Add code highlighting to code samples (all
sh
ell here).
Co-authored-by: Allen Dean <[email protected]>
Co-authored-by: Allen Dean <[email protected]>
Co-authored-by: Allen Dean <[email protected]>
Co-authored-by: Allen Dean <[email protected]>
Co-authored-by: Allen Dean <[email protected]>
Co-authored-by: Allen Dean <[email protected]>
Co-authored-by: Allen Dean <[email protected]>
Co-authored-by: Allen Dean <[email protected]>
Co-authored-by: Allen Dean <[email protected]>
Co-authored-by: Allen Dean <[email protected]>
Co-authored-by: Allen Dean <[email protected]>
Co-authored-by: Allen Dean <[email protected]>
Co-authored-by: Allen Dean <[email protected]>
Co-authored-by: Allen Dean <[email protected]>
/run pipeline |
Style edits. Should not change the accuracy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran this through our style checker and committed changes here. Make sure everything is still accurate.
/run pipeline |
/run pipeline |
/run pipeline |
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Issue - https://github.ibm.com/GoldenEye/issues/issues/5390
It adds steps to access api endpoint deployed in OCP via CIS.
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
Merge actions for mergers