Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: documenting the flags issue in CAA record #384

Merged
merged 18 commits into from
Sep 30, 2023
Merged

Conversation

iamar7
Copy link
Member

@iamar7 iamar7 commented Sep 28, 2023

Description

This PR adds a documentation in the DNS readme for the flags issue in CAA record.
https://github.ibm.com/GoldenEye/issues/issues/6012

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

  • When merging, use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
  • Merge by using "Squash and merge".

@iamar7
Copy link
Member Author

iamar7 commented Sep 28, 2023

/run pipeline

Copy link
Member

@maheshwarishikha maheshwarishikha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not do numbering.

@iamar7
Copy link
Member Author

iamar7 commented Sep 28, 2023

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Sep 28, 2023

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Sep 28, 2023

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Sep 28, 2023

/run pipeline

Copy link
Contributor

@SirSpidey SirSpidey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have more questions than suggestions.

modules/dns/README.md Outdated Show resolved Hide resolved
modules/dns/README.md Outdated Show resolved Hide resolved
@maheshwarishikha
Copy link
Member

/run pipeline

@maheshwarishikha maheshwarishikha requested review from SirSpidey and removed request for SirSpidey September 29, 2023 13:44
Copy link
Contributor

@SirSpidey SirSpidey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small change to get to the issue.

modules/dns/README.md Outdated Show resolved Hide resolved
@maheshwarishikha
Copy link
Member

/run pipeline

@maheshwarishikha
Copy link
Member

@SirSpidey Thanks for your review. Have made the changes as requested. It should be good to go. Thanks

Copy link
Contributor

@SirSpidey SirSpidey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed one link syntax.

@maheshwarishikha
Copy link
Member

/run pipeline

@maheshwarishikha
Copy link
Member

/run pipeline

@jojustin jojustin merged commit 0ca023e into main Sep 30, 2023
@jojustin jojustin deleted the documentation branch September 30, 2023 13:53
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants