Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update markdown documents #386

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Update markdown documents #386

wants to merge 15 commits into from

Conversation

vburckhardt
Copy link
Member

LLM-Assisted Editing Enhancement

To make the most of your modifications or further developments, it's advisable to use the specific branch from which this Pull Request (PR) originates. This will ensure you have a solid and up-to-date foundation for your tweaks and enhancements.

Using Markdown LLM Corrector.

@vburckhardt vburckhardt requested review from SirSpidey and removed request for SirSpidey January 17, 2024 13:32
@vburckhardt
Copy link
Member Author

Hello @SirSpidey - thoughts on this initial version? Not 100% perfect, but perhaps it can be used as a good basis doing 80% of the work.

@vburckhardt vburckhardt changed the title Update markdown documents DRAFT: Update markdown documents Jan 17, 2024
@vburckhardt
Copy link
Member Author

/run pipeline

@vburckhardt vburckhardt changed the title DRAFT: Update markdown documents Update markdown documents Jan 17, 2024
Copy link
Contributor

@SirSpidey SirSpidey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bunch of suggestions for this pass. Let me know if they don't make sense.

@@ -147,4 +147,4 @@ You need the following permissions to run this module.

You can report issues and request features for this module in GitHub issues in the module repo. See [Report an issue or request a feature](https://github.com/terraform-ibm-modules/.github/blob/main/.github/SUPPORT.md).

To set up your local development environment, see [Local development setup](https://terraform-ibm-modules.github.io/documentation/#/local-dev-setup) in the project documentation.
To set up your local development environment, see [Local Development Setup](https://terraform-ibm-modules.github.io/documentation/#/local-dev-setup) in the project documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is correct as it was, with sentence case (Local development setup).

@@ -1,20 +1,20 @@
# Pre-wired CBR configuration for FS Cloud example
# Pre-wired CBR Configuration for FS Cloud Example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalization was correct in the original

examples/fscloud/README.md Outdated Show resolved Hide resolved
examples/fscloud/README.md Outdated Show resolved Hide resolved
examples/fscloud/README.md Outdated Show resolved Hide resolved
modules/fscloud/README.md Outdated Show resolved Hide resolved
modules/fscloud/README.md Outdated Show resolved Hide resolved
@@ -2,7 +2,7 @@

# Tests

For information about how to create and run tests, see [Validation tests](https://terraform-ibm-modules.github.io/documentation/#/tests) in the project documentation.
For information about how to create and run tests, see [Validation Tests](https://terraform-ibm-modules.github.io/documentation/#/tests) in the project documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capitalization was correct in original

README.md Outdated Show resolved Hide resolved
Comment on lines +22 to +26
* [CBR Multi Service Profile](./examples/multi-service-profile)
* [Multi-Resource Rule Example](./examples/multi-resource-rule)
* [Multi-zone Example](./examples/multizone-rule)
* [Pre-wired CBR Configuration for FS Cloud Example](./examples/fscloud)
* [Zone Example](./examples/zone)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should all go back to the original capitalization after the files are updated and the pre-commit hook runs.

@SirSpidey
Copy link
Contributor

@vburckhardt I think I missed the point of this PR. I reviewed the content as I would normally. I didn't realize until now that it was an update from an LLM.

I think it could be good to check how well this performs against the Vale tool that we have available for Cloud docs.

Does pretty well

  • hyphenates words correctly
  • updates e.g., correctly. But it should replace Latin expressions.

Doesn't match IBM style, grammar, and terminology

  • Uses headline capitalization instead of sentence capitalization.
  • Puts "only" in the wrong place. (misplaced only)
  • Doesn't replace product/offering names with the approved ones.

Doesn't match tech writing practices

  • Word replacement is spotty. Sometimes it replaces simple words, especially words that are used more than once in the same sentence or paragraph (for example, use), with words that don't help the reader (like leverage and utilize). I'd characterize these changes as the things that a writing teacher would do, but they're not helpful for tech writing.
  • Doesn't reorganize ideas to keep similar ones together.

@ocofaigh
Copy link
Member

@SirSpidey I was about to mention that the tool seems to be telling us to do capitilazation in places you told us not to :) For example here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants