Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable new endpoint type for cluster config #277

Merged

Conversation

toddgiguere
Copy link
Contributor

Description

In order to fully support OCP 4.13 with disabled public endpoint, the IBM provider team has added a new parameter endpoint_type to the ibm_container_cluster_config data block to specify an endpoint type that may not be the default.

Added a new input parameter to provide the endpoint type to this module, and use this module in the ibm_container_cluster_config data block.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Added new input variable cluster_config_endpoint_type that will be passed into the new parameter endpoint_type for the ibm_container_cluster_config data block used in this module.

This change will allow you to specify a different endpoint for cluster configuration than the default, for instance if using OCP 4.13 with public endpoint disabled, and you do not want to use the default endpoint of VPE, you can now specify "private" to use the private endpoint.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@toddgiguere
Copy link
Contributor Author

/run pipeline

@toddgiguere
Copy link
Contributor Author

Standard test failed when downloading cluster config in base module:

"The cluster is not fully deployed yet. Wait a few minutes, then try again."

All other tests passed though, which also use same logic, so I'm assuming this is a one-off timing issue, and I'll run pipeline again

@toddgiguere
Copy link
Contributor Author

/run pipeline

@toddgiguere
Copy link
Contributor Author

/run pipeline

@toddgiguere toddgiguere requested a review from ocofaigh November 7, 2023 19:22
@ocofaigh ocofaigh merged commit 18f58ba into terraform-ibm-modules:main Nov 7, 2023
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants