Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for v5 of google and google-beta providers #360

Closed
busser opened this issue Oct 4, 2023 · 7 comments
Closed

Add support for v5 of google and google-beta providers #360

busser opened this issue Oct 4, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@busser
Copy link

busser commented Oct 4, 2023

TL;DR

The google and google-beta providers recently got a new major version, v5.
The modules in this repo currently don't support it:

google = {
  source  = "hashicorp/google"
  version = ">= 4.50, < 5.0"
}
google-beta = {
  source  = "hashicorp/google-beta"
  version = ">= 4.50, < 5.0"
}

This is stopping users from migrating to the new major version.

Terraform Resources

No response

Detailed design

No response

Additional information

No response

@busser busser added the enhancement New feature or request label Oct 4, 2023
@huntedman
Copy link

huntedman commented Oct 23, 2023

There's a pending PR for it, but no action from maintainers.

#364

So the best bet is to just fork it, fix it yourself and just use your fork 🤷‍♂️

@descampsk
Copy link

Really sad that the Google Terraform module is not well maintained 😢
I have to migrate out and will really think about using these modules in the futur

@huntedman
Copy link

Really sad that the Google Terraform module is not well maintained 😢 I have to migrate out and will really think about using these modules in the futur

To be honest, it's pretty easy and straightforward to solve via a fork. The downside being you need to maintain the code.

But Looking at the actual code in the modules, I ended up not even using this module, and getting a better idea of how to solve it for my use case.

@descampsk
Copy link

Yeah but the purpose of the module is to reduce my maintenance of my code ^^.
If I have to maintain a fork, it is just better to use the terraform resources directly 😉

@imrannayer
Copy link
Collaborator

@huntedman #364 is not the correct PR for this. PR for this is #363 . It is failing test which is blocking the rollout.

@imrannayer
Copy link
Collaborator

Fixed in #374

@clintonb
Copy link

clintonb commented Nov 2, 2023

@imrannayer any idea when we can expect a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants