feat: Add support for configuring pubsub object notifications #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgante
force-pushed
the
feat/notifications
branch
from
41ffbf6 to
4ce1954
Compare
bharathkkb
reviewed
Apr 19, 2020
| # project_id = var.project_id | ||
| bucket = lookup(each.value, "bucket") | ||
| payload_format = "JSON_API_V1" | ||
|
|
There was a problem hiding this comment.
Looking at the google_storage_notification resource docs I think object_name_prefix and custom_attributes seem useful to be user configurable.
bharathkkb
reviewed
Apr 19, 2020
| */ | ||
|
|
||
| locals { | ||
| # [for o in var.list : o.interfaces[0].name] |
There was a problem hiding this comment.
nit: I think you meant to remove this?
bharathkkb
reviewed
Apr 19, 2020
| resource "google_storage_notification" "notifications" { | ||
| for_each = var.bucket_configs | ||
|
|
||
| # project_id = var.project_id |
There was a problem hiding this comment.
nit: I think you meant to remove this?
bharathkkb
reviewed
Apr 19, 2020
| @@ -138,3 +138,9 @@ variable "lifecycle_rules" { | |||
| description = "List of lifecycle rules to configure. Format is the same as described in provider documentation https://www.terraform.io/docs/providers/google/r/storage_bucket.html#lifecycle_rule except condition.matches_storage_class should be a comma delimited string." | |||
| default = [] | |||
| } | |||
|
|
|||
| variable "pubsub_topics" { | |||
There was a problem hiding this comment.
Suggested change
| variable "pubsub_topics" { | |
| variable "pubsub_notification_topics" { |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28