Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates edit column menu to support hparam columns #6738

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
89fc04a
Adds shared hparam related common selectors
hoonji Jan 24, 2024
bed9604
Fixes test description
hoonji Jan 24, 2024
9eef734
Fixes formatting
hoonji Jan 24, 2024
f72b2a2
Changes reorder column events to use source and destination
hoonji Jan 25, 2024
f3130d0
Fixes lint
hoonji Jan 25, 2024
a9c53c3
Runs buildifier
hoonji Jan 25, 2024
f17fe22
Turns groupColumns into a projector function helper
hoonji Jan 26, 2024
555a84e
Merge branch 'hparam_common_selectors' into hparam_update_reorder
hoonji Jan 26, 2024
6e45e6e
Makes runs table use hparam store for hparam columns
hoonji Jan 26, 2024
ec93a93
Changes ColumnGroup to enum
hoonji Jan 27, 2024
cff6ce3
Merge branch 'hparam_common_selectors' into hparam_update_reorder
hoonji Jan 27, 2024
c17894d
Applies comments
hoonji Jan 27, 2024
694251c
Merge branch 'hparam_update_reorder' into hparam_runs_hparams
hoonji Jan 27, 2024
ff8c096
Applies comments
hoonji Jan 27, 2024
999bffc
Adds hparams to scalar tables
hoonji Jan 28, 2024
aff157d
Adds hparams to column editor
hoonji Jan 29, 2024
d3f2cb9
Fixes card view stacking context
hoonji Jan 29, 2024
62f4099
Applies fixes
hoonji Jan 29, 2024
e96b32a
Fixes lint error
hoonji Jan 29, 2024
7f39b54
Fixes lint error
hoonji Jan 29, 2024
ef301e5
Merge branch 'hparam_update_reorder' into hparam_runs_hparams
hoonji Jan 29, 2024
06b550e
Merge branch 'hparam_runs_hparams' into hparam_scalar_table_hparams
hoonji Jan 29, 2024
2445ba3
Merge branch 'hparam_scalar_table_hparams' into hparam_column_editor_…
hoonji Jan 29, 2024
8b2df63
Fixes
hoonji Jan 29, 2024
dd390f0
Revert card view layout paint
hoonji Jan 29, 2024
0e210b2
More fixes
hoonji Jan 29, 2024
8f95404
Move contain layout paint to original position
hoonji Jan 29, 2024
2a5156d
Merge branch 'hparam_scalar_table_hparams' into hparam_column_editor_…
hoonji Jan 29, 2024
5fe3551
Fix strange merge
hoonji Jan 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes lint
  • Loading branch information
hoonji committed Jan 25, 2024
commit f3130d0fa7403cdf09b229b1014f5a2ad0e30439
4 changes: 1 addition & 3 deletions tensorboard/webapp/hparams/_redux/hparams_reducers.ts
Original file line number Diff line number Diff line change
@@ -13,9 +13,7 @@ See the License for the specific language governing permissions and
limitations under the License.
==============================================================================*/
import {Action, ActionReducer, createReducer, on} from '@ngrx/store';
import {
Side,
} from '../../widgets/data_table/types';
import {Side} from '../../widgets/data_table/types';
import {DataTableUtils} from '../../widgets/data_table/utils';
import * as actions from './hparams_actions';
import {HparamsState} from './types';
Original file line number Diff line number Diff line change
@@ -44,11 +44,7 @@ import {
TooltipDatum,
} from '../../../widgets/line_chart_v2/types';
import {CardState} from '../../store';
import {
HeaderEditInfo,
TooltipSort,
XAxisType,
} from '../../types';
import {HeaderEditInfo, TooltipSort, XAxisType} from '../../types';
import {
MinMaxStep,
ScalarCardDataSeries,