From 8324f32d0ca0830019602def57870850dcc9627a Mon Sep 17 00:00:00 2001 From: Brian Dubois Date: Tue, 3 Oct 2023 10:43:39 -0400 Subject: [PATCH] MDCMigration: Style data table row heights for MDC migration. --- .../metrics/views/card_renderer/scalar_card_data_table.scss | 5 +++++ .../webapp/runs/views/runs_table/runs_data_table.scss | 4 +++- .../webapp/widgets/data_table/content_cell_component.scss | 2 +- .../webapp/widgets/data_table/header_cell_component.scss | 1 - 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/tensorboard/webapp/metrics/views/card_renderer/scalar_card_data_table.scss b/tensorboard/webapp/metrics/views/card_renderer/scalar_card_data_table.scss index 632accf973..0a75646c45 100644 --- a/tensorboard/webapp/metrics/views/card_renderer/scalar_card_data_table.scss +++ b/tensorboard/webapp/metrics/views/card_renderer/scalar_card_data_table.scss @@ -14,6 +14,11 @@ limitations under the License. ==============================================================================*/ $_circle-size: 12px; +tb-data-table-content-cell, +tb-data-table-header-cell { + padding: 4px; +} + .row-circle { height: $_circle-size; width: $_circle-size; diff --git a/tensorboard/webapp/runs/views/runs_table/runs_data_table.scss b/tensorboard/webapp/runs/views/runs_table/runs_data_table.scss index 9fad68e486..6fe5224970 100644 --- a/tensorboard/webapp/runs/views/runs_table/runs_data_table.scss +++ b/tensorboard/webapp/runs/views/runs_table/runs_data_table.scss @@ -48,11 +48,13 @@ $_arrow_size: 16px; tb-data-table-content-row, tb-data-table-header-cell { - height: 44px; + // Match the size of the touch targets for the checkbox. + height: 48px; } tb-data-table-content-cell, tb-data-table-header-cell { + padding: 0 4px; vertical-align: middle; @include tb-theme-foreground-prop(border-bottom, border, 1px solid); diff --git a/tensorboard/webapp/widgets/data_table/content_cell_component.scss b/tensorboard/webapp/widgets/data_table/content_cell_component.scss index 54a9dcfd8e..dbdcf5ee6c 100644 --- a/tensorboard/webapp/widgets/data_table/content_cell_component.scss +++ b/tensorboard/webapp/widgets/data_table/content_cell_component.scss @@ -15,8 +15,8 @@ limitations under the License. :host { display: table-cell; - padding: 4px; } + .cell { align-items: center; display: flex; diff --git a/tensorboard/webapp/widgets/data_table/header_cell_component.scss b/tensorboard/webapp/widgets/data_table/header_cell_component.scss index 71f09d1761..72d0d57559 100644 --- a/tensorboard/webapp/widgets/data_table/header_cell_component.scss +++ b/tensorboard/webapp/widgets/data_table/header_cell_component.scss @@ -21,7 +21,6 @@ $_icon_size: 12px; :host { display: table-cell; - padding: 4px; vertical-align: bottom; &:hover {