Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

ODS: OptionalAttr doesn't lead to generation of builder method with attribute arguments unspecified #220

Open
bondhugula opened this issue Nov 4, 2019 · 1 comment
Open

ODS: OptionalAttr doesn't lead to generation of builder method with attribute arguments unspecified #220

bondhugula opened this issue Nov 4, 2019 · 1 comment
Assignees
@antiagainst

Comments

@bondhugula
Copy link
Contributor

I noticed that using OptionalAttr doesn't generate a builder method version that doesn't have the attribute as an argument. I also noticed this comment:

mlir/include/mlir/Dialect/Linalg/IR/LinalgLibraryOps.td

Line 240 in a4b11eb

// TODO(ntv) this should go away once the usage of OptionalAttr triggers

Is this still a TODO?
@antiagainst antiagainst self-assigned this Nov 4, 2019
@antiagainst
Copy link
Contributor

Yes this is a missing feature not yet supported.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@antiagainst antiagainst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antiagainst @bondhugula