Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

Hot config reloads #183

Open
jleni opened this issue Feb 25, 2019 · 2 comments
Open

Hot config reloads #183

jleni opened this issue Feb 25, 2019 · 2 comments

Comments

@jleni
Copy link
Contributor

jleni commented Feb 25, 2019

It would nice to have something similar to tmkms refresh to reload changes in the configuration file without having to restart the complete KMS.

Yeah, we should definitely support hot config reloads. Feel free to open an issue.

Originally posted by @tarcieri in #177 (comment)

@liangping
Copy link

how about tmkms reload

@tarcieri
Copy link
Contributor

Abscissa 0.1 (unreleased) now contains the prerequisites for hot config reloads, including a signal-hook based signal handler which processes all signals by obtaining an exclusive mutable reference to the application state.

KMS doesn't use it yet: I'm trying to keep the initial Abscissa upgrade as light touch as possible. But after KMS v0.6 is released, we should be able to switch to it and handle config reloads via e.g. SIGHUP.

After that, we could potentially add friendlier ways to send that SIGHUP like @liangping's suggested tmkms reload.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants