Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDOW_UPDATE on ingress traffic #1810

Closed
krizhanovsky opened this issue Feb 6, 2023 · 1 comment
Closed

WINDOW_UPDATE on ingress traffic #1810

krizhanovsky opened this issue Feb 6, 2023 · 1 comment

Comments

@krizhanovsky
Copy link
Contributor

krizhanovsky commented Feb 6, 2023

Motivation

At the moment Tempesta FW announces SETTINGS_INITIAL_WINDOW_SIZE as 2^31-1 (the maximum value) and never updates the window to a client. This may lead to hung connection if a client upload reaches 2GB size.

Scope

#1394 extends TfwStream with the current flow-control window, which also must be tracked on ingress streams and updated (send WINDOW_UPDATE) to a peer, when it reaches 0.

Testing

Just try to upload something like 3GB of data. Probably use some C program for the client to make it faster. Please also update the issue with the resulting transfer speed.

@krizhanovsky
Copy link
Contributor Author

Fixed in #2009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants