Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generate static responses #163

Closed
krizhanovsky opened this issue Jul 23, 2015 · 2 comments
Closed

Do not generate static responses #163

krizhanovsky opened this issue Jul 23, 2015 · 2 comments

Comments

@krizhanovsky
Copy link
Contributor

krizhanovsky commented Jul 23, 2015

Currently static responses like 30x or 50x responses are generated for each case with skb and pool allocations, and that's not good for performance. Rather the responses should be made from request skbs which lead to the error response.

Since we need very similar skb modifications, the issue is somewhat linked with #47.

Basically, it seems all the Web servers allow to write custom error response HTML pages, so we have to keep such pages in the Web cache and provide interface to a user to modify the pages.

@krizhanovsky krizhanovsky added this to the TBD milestone Jul 23, 2015
@krizhanovsky krizhanovsky modified the milestones: 0.5.0 Web Server, 0.6 TBD Oct 9, 2015
@krizhanovsky
Copy link
Contributor Author

krizhanovsky commented Dec 19, 2015

Somewhat linked with #123.

The fix of #658 (Client friendly requests blocking) introduces static response bodies which are copied now to skbs. Meantime, we can just reuse them as skb page fragments.

@krizhanovsky krizhanovsky modified the milestones: 0.6 WebOS, 0.5.0 Web Server Feb 12, 2017
@krizhanovsky krizhanovsky modified the milestones: backlog, 0.8 TDB v0.2 Jan 9, 2018
@krizhanovsky krizhanovsky modified the milestones: 1.2 TDB v0.2, 1.4 Kernel-User Space Transport Aug 8, 2018
@krizhanovsky krizhanovsky modified the milestones: 1.4 Kernel-User Space Transport , 0.7 HTTP/2 Sep 9, 2018
@krizhanovsky
Copy link
Contributor Author

With HTTP/2 we can not pre-generate HTTP messages: any message must be encrypted by a session key and framed according to current streams prioritization and window #1196 , so the task is only about skb reusage. skb reusage is essentially just about avoiding allocation of skb since we still need to rewrite all its fields, and this is point 5 of #391.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants