-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not generate static responses #163
Labels
Milestone
Comments
With HTTP/2 we can not pre-generate HTTP messages: any message must be encrypted by a session key and framed according to current streams prioritization and window #1196 , so the task is only about skb reusage. skb reusage is essentially just about avoiding allocation of skb since we still need to rewrite all its fields, and this is point 5 of #391. |
This was referenced May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently static responses like 30x or 50x responses are generated for each case with skb and pool allocations, and that's not good for performance. Rather the responses should be made from request skbs which lead to the error response.
Since we need very similar skb modifications, the issue is somewhat linked with #47.
Basically, it seems all the Web servers allow to write custom error response HTML pages, so we have to keep such pages in the Web cache and provide interface to a user to modify the pages.
The text was updated successfully, but these errors were encountered: