-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash on converting mixed headers from h1 to h2 #1408
Comments
I can assure that #1450 fixes a crash on serving cached responses for me with the configuration provided in the original issue message. But in the chat we discussed that crash on forwarded is hard to reproduce. Today I run into it with the following configuration: Tempesta: at branch #1450 (the branch fixes only
A block was added to backend configuration (nginx in my case):
Just make a single request:
Tempesta crashes on this test case:
|
The Nginx configuration is quite fancy, shouldn't we add it to the functional tests? |
Scope
Configure backend to send headers in mixed order: put header
B
between two headersA
. e.g.:The crash will happen once the message is converted from h1 to h2. This may happen in two places:
The issue doesn't reproduced if h2 request contains mixed headers orders.
Probably related to #1387
Testing
Currently we have very limited h2 test coverage, only basic GET/POST request. It's possible to extend them, but more sophisticated fussing test is required.
Logs
Crash on caching:
Coudn't reproduce the crash on the same short response right away, but seen it multiple times. Anyway h2 clients complain about h2 frame content:
Crash on bigger responses constructed the same way:
The text was updated successfully, but these errors were encountered: