Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added poly and mainnet diamond extensions #495

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

added poly and mainnet diamond extensions #495

wants to merge 3 commits into from

Conversation

elclandestin0
Copy link
Contributor

It creates an extension for both mainnet and polygon networks

@elclandestin0 elclandestin0 requested a review from a team as a code owner October 15, 2021 03:32
@elclandestin0 elclandestin0 temporarily deployed to testing-keys October 15, 2021 03:32 Inactive
passabilities
passabilities requested changes Oct 15, 2021
View reviewed changes
deploy/protocol.ts Outdated Show resolved Hide resolved
dumebi
dumebi suggested changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@dumebi dumebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check the failed tests, seems a file is missing

@elclandestin0 elclandestin0 temporarily deployed to testing-keys October 15, 2021 15:17 Inactive
@elclandestin0 elclandestin0 temporarily deployed to testing-keys October 15, 2021 20:33 Inactive
@elclandestin0 elclandestin0 temporarily deployed to testing-keys October 15, 2021 20:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dumebi dumebi dumebi requested changes

@passabilities passabilities passabilities requested changes

@ethereumdegen ethereumdegen Awaiting requested review from ethereumdegen ethereumdegen is a code owner automatically assigned from teller-protocol/solidity-devs

@sypeer sypeer Awaiting requested review from sypeer sypeer is a code owner automatically assigned from teller-protocol/solidity-devs

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elclandestin0 @passabilities @dumebi