Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROTOCOL-690: Feature/aave claim aave #454

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from
Open

PROTOCOL-690: Feature/aave claim aave #454

wants to merge 24 commits into from

Conversation

dumebi
Copy link
Contributor

@dumebi dumebi commented Jul 21, 2021

Implemented AaveClaimAaveFacet to claim accrued aave coins

@dumebi dumebi requested review from a team, ethereumdegen, passabilities and sypeer and removed request for a team July 21, 2021 21:39
@dumebi dumebi temporarily deployed to testing-keys July 21, 2021 21:39 Inactive
@dumebi dumebi requested a review from a team as a code owner July 21, 2021 22:10
@dumebi dumebi temporarily deployed to testing-keys July 21, 2021 22:10 Inactive
@dumebi dumebi temporarily deployed to testing-keys July 21, 2021 22:10 Inactive
@dumebi dumebi temporarily deployed to testing-keys July 22, 2021 07:11 Inactive
@dumebi dumebi temporarily deployed to testing-keys July 22, 2021 07:11 Inactive
Base automatically changed from feature/story-test/develop to develop July 26, 2021 22:52
@passabilities passabilities temporarily deployed to testing-keys July 26, 2021 23:38 Inactive
@passabilities passabilities temporarily deployed to testing-keys July 26, 2021 23:38 Inactive
passabilities
passabilities requested changes Jul 26, 2021
View reviewed changes
config/dapps.ts Outdated Show resolved Hide resolved
test/helpers/story/drivers/dapp-utils/aave.utils.ts Show resolved Hide resolved
@passabilities passabilities temporarily deployed to testing-keys July 27, 2021 15:35 Inactive
@passabilities passabilities temporarily deployed to testing-keys July 27, 2021 15:35 Inactive
@dumebi dumebi temporarily deployed to testing-keys July 28, 2021 20:21 Inactive
@dumebi dumebi temporarily deployed to testing-keys July 28, 2021 20:21 Inactive
@dumebi dumebi temporarily deployed to testing-keys July 28, 2021 20:45 Inactive
@dumebi dumebi requested a review from passabilities July 28, 2021 20:47
@dumebi dumebi temporarily deployed to testing-keys July 29, 2021 09:16 Inactive
@dumebi dumebi dismissed passabilities’s stale review August 20, 2021 17:31

resolved, its still showing this

dumebi and others added 24 commits October 13, 2021 19:18
@dumebi
chore: aave claimAave solidity code
729c552
@dumebi
rebased feature/create-loan-nft-v2
880ea46
@dumebi
rebased with feature/create-loan-nft-v2
a87bfec
@passabilities @dumebi
Fix chai BN array assertion
53e795b
@passabilities @dumebi
Add Aave incentives controller for Polygon
0221d43
@passabilities @dumebi
Update BN equal check
08ba5fc
@passabilities @dumebi
Fix comment
2d67533
@passabilities @dumebi
Update Compound & Aave claim
2132984
@passabilities @dumebi
Remove file
534b1d1
@dumebi
fix test on polygon
2d6afee
@dumebi
fixed review comments
cc7557c
@dumebi
chore: redeem staked aave
d6e504f
@dumebi
remove compound address from polygon
fdbbcc5
@dumebi
remove documentation relative to comp on claimAave
dc67080
@dumebi
chore: add getNetworkName to protocol
e2194d3
@dumebi
claim aave and comp conditionally to user or escrow
9caed4a
@dumebi
patch fix accrued comp and aave
34aed04
@dumebi
fix: comp and aave to user
b542d5c
@dumebi
aave lending pool
f7f6159
@dumebi
fix review changes
fab0417
@dumebi
fix tokenUpdated parameters
d6dd7d7
@dumebi
fixed parameter reviews
5006700 
updated `tokenUpdated` function to include comp
added function params for comp and aave
@dumebi
remove console.log
848ee34
@dumebi
testing compAccrued
a79d085
@dumebi dumebi force-pushed the feature/AaveClaimAave branch from 3db107b to a79d085 Compare October 13, 2021 18:42
@dumebi dumebi temporarily deployed to testing-keys October 13, 2021 18:42 Inactive
@dumebi dumebi temporarily deployed to testing-keys October 13, 2021 18:42 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sypeer sypeer Awaiting requested review from sypeer

@elclandestin0 elclandestin0 Awaiting requested review from elclandestin0

@passabilities passabilities Awaiting requested review from passabilities

@ethereumdegen ethereumdegen Awaiting requested review from ethereumdegen

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
P1 Priority level HIGH
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dumebi @ethereumdegen @passabilities @sypeer