Skip to content

๐Ÿ˜บGithub Rule

์กฐ์ฐฌ์˜ edited this page Nov 16, 2020 · 13 revisions

git workflow

๊ธฐ์กด์˜ github-flow์—์„œ ๊ฐ™์€ ๊ธฐ๋Šฅ์„ ์—ฌ๋Ÿฌ ๊ฐœ๋ฐœ์ž๊ฐ€ ๋ถ„์—…ํ•ด ๊ฐœ๋ฐœํ•˜๊ธฐ ์œ„ํ•ด user๋ผ๋Š” ๋ธŒ๋žœ์น˜๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ์šฐ๋ฆฌ๋งŒ์˜ workflow๋ฅผ ๋งŒ๋“ค์–ด ์ž‘์—…ํ•˜๊ณ  ์žˆ๋‹ค.

flow

  • ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ
    • master โ†” hotfix
    • feature/[feature-name]
    • feature/[feature-name]/[name-initial]
      • ex) feature/login/kej

PR ์ปจ๋ฒค์…˜

### PR ์ œ๋ชฉ ํ…œํ”Œ๋ฆฟ
์ œ๋ชฉ์€ ๋‹ค์Œ๊ณผ ๊ฐ™์ด ์ž‘์„ฑํ•˜๊ณ , ํ…œํ”Œ๋ฆฟ ๋‚ด์šฉ์€ ์ง€์›Œ์ฃผ์„ธ์š”.
> [์ด๋ฆ„ ์ด๋‹ˆ์…œ] ์ž‘์—… ๋‚ด์šฉ ๊ฐ„๋žตํ•˜๊ฒŒ ์ž‘์„ฑ

### ์ž‘์—… ์‚ฌํ•ญ
- [x] ์™„๋ฃŒ ๋ชฉ๋ก
- [ ] ์ง„ํ–‰์ค‘ ๋ชฉ๋ก

### ์š”์•ฝ
์ด๊ณณ์— ์š”์•ฝ ๋‚ด์šฉ์„ ์“ฐ์„ธ์š”.

### ์ฒจ๋ถ€
์ž‘์—…ํ•œ ์‚ฌ์ง„์„ ์ฒจ๋ถ€ํ•  ๊ฒฝ์šฐ ์—ฌ๊ธฐ์— ์ถ”๊ฐ€ํ•˜์„ธ์š”.

### ์ด์Šˆ
ํ•ด๋‹น ์ž‘์—… ๊ด€๋ จ ์ด์Šˆ๋ฅผ ํƒœ๊ทธํ•ด์ฃผ์„ธ์š”.
  • ๋ฆฌ๋ทฐ์–ด์— ํŒ€์› ์ง€์ •ํ•˜๊ธฐ.
  • ๋ชจ๋“  ํŒ€์›์—๊ฒŒ ๋ฆฌ๋ทฐ๋ฅผ ๋ฐ›์•„์•ผ ๋จธ์ง€๊ฐ€ ๊ฐ€๋Šฅํ•˜๋‹ค.
  • ๋ฆฌ๋ทฐํ• ๊ฒŒ ์—†์œผ๋ฉด ์นญ์ฐฌ์ด๋ผ๋„ ํ•˜์ž!
  • ์ˆ˜์ •ํ•  ์‚ฌํ•ญ์ด ์žˆ์œผ๋ฉด pending์œผ๋กœ ๋ฆฌ๋ทฐํ•˜๊ธฐ.