Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make resolvers' maximum resolution timeout configurable #8366

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make resolvers' maximum resolution timeout configurable #8366

wants to merge 1 commit into from

Conversation

jkhelil
Copy link
Member

@jkhelil jkhelil commented Nov 5, 2024 •
edited
Loading

Changes

  • The default-maximum-resolution-timeout can now be configured in the config-defaults configmap.
  • The fetch-timeout is a new field in the bundleresolver-config ConfigMap, allowing you to set the timeout for bundle resolution requests
  • provide a resolver-with-timeout for testing

fixes #6025

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesnt merit a release note. labels Nov 5, 2024
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 5, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go 91.9% 86.6% -5.4
pkg/reconciler/resolutionrequest/controller.go 85.7% 90.0% 4.3
pkg/reconciler/resolutionrequest/resolutionrequest.go 80.0% 81.2% 1.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go 91.9% 86.6% -5.4
pkg/reconciler/resolutionrequest/controller.go 85.7% 90.0% 4.3
pkg/reconciler/resolutionrequest/resolutionrequest.go 80.0% 81.2% 1.2

@jkhelil
Copy link
Member Author

jkhelil commented Nov 5, 2024

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Nov 5, 2024
@jkhelil jkhelil force-pushed the resolution_timeout branch from 565470b to dc809f9 Compare November 5, 2024 12:56
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go 91.9% 86.6% -5.4
pkg/reconciler/resolutionrequest/controller.go 85.7% 90.0% 4.3
pkg/reconciler/resolutionrequest/resolutionrequest.go 80.0% 81.2% 1.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go 91.9% 86.6% -5.4
pkg/reconciler/resolutionrequest/controller.go 85.7% 90.0% 4.3
pkg/reconciler/resolutionrequest/resolutionrequest.go 80.0% 81.2% 1.2

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go 91.9% 86.6% -5.4
pkg/reconciler/resolutionrequest/controller.go 85.7% 90.0% 4.3
pkg/reconciler/resolutionrequest/resolutionrequest.go 80.0% 81.2% 1.2

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go 91.9% 86.6% -5.4
pkg/reconciler/resolutionrequest/controller.go 85.7% 90.0% 4.3
pkg/reconciler/resolutionrequest/resolutionrequest.go 80.0% 81.2% 1.2

@jkhelil jkhelil changed the title WIP make the maximum resolution timeout configurable through defaultconfi… WIP make the maximum resolution timeout configurable Nov 7, 2024
@jkhelil jkhelil force-pushed the resolution_timeout branch from fbd7f4e to 22e881b Compare November 7, 2024 09:37
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go 91.9% 86.6% -5.4
pkg/reconciler/resolutionrequest/controller.go 85.7% 90.0% 4.3
pkg/reconciler/resolutionrequest/resolutionrequest.go 80.0% 81.2% 1.2
pkg/resolution/resolver/bundle/resolver.go 96.6% 94.3% -2.3

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go 91.9% 86.6% -5.4
pkg/reconciler/resolutionrequest/controller.go 85.7% 90.0% 4.3
pkg/reconciler/resolutionrequest/resolutionrequest.go 80.0% 81.2% 1.2
pkg/resolution/resolver/bundle/resolver.go 96.6% 94.3% -2.3

@jkhelil jkhelil changed the title WIP make the maximum resolution timeout configurable make the maximum resolution timeout configurable Nov 7, 2024
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
vdemeester
vdemeester approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @afrittoli

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2024
@jkhelil
Copy link
Member Author

jkhelil commented Nov 8, 2024

/hold
I am adding a resolver-with-timeout to test the PR

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
@jkhelil jkhelil force-pushed the resolution_timeout branch from 22e881b to 2354191 Compare November 8, 2024 14:31
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 8, 2024
@jkhelil
Copy link
Member Author

jkhelil commented Nov 8, 2024

/unhold

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go 91.9% 86.6% -5.4
pkg/reconciler/resolutionrequest/controller.go 85.7% 90.9% 5.2
pkg/reconciler/resolutionrequest/resolutionrequest.go 80.0% 81.2% 1.2
pkg/resolution/resolver/bundle/resolver.go 96.6% 94.3% -2.3

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go 91.9% 86.6% -5.4
pkg/reconciler/resolutionrequest/controller.go 85.7% 90.9% 5.2
pkg/reconciler/resolutionrequest/resolutionrequest.go 80.0% 81.2% 1.2
pkg/resolution/resolver/bundle/resolver.go 96.6% 94.3% -2.3

@jkhelil jkhelil force-pushed the resolution_timeout branch from 2354191 to 2edbf50 Compare November 8, 2024 17:18
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go 91.9% 86.6% -5.4
pkg/reconciler/resolutionrequest/controller.go 85.7% 90.9% 5.2
pkg/reconciler/resolutionrequest/resolutionrequest.go 80.0% 81.2% 1.2
pkg/resolution/resolver/bundle/resolver.go 96.6% 94.3% -2.3

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go 91.9% 86.6% -5.4
pkg/reconciler/resolutionrequest/controller.go 85.7% 90.9% 5.2
pkg/reconciler/resolutionrequest/resolutionrequest.go 80.0% 81.2% 1.2
pkg/resolution/resolver/bundle/resolver.go 96.6% 94.3% -2.3

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go 91.9% 86.6% -5.4
pkg/reconciler/resolutionrequest/controller.go 85.7% 90.9% 5.2
pkg/reconciler/resolutionrequest/resolutionrequest.go 80.0% 81.2% 1.2
pkg/resolution/resolver/bundle/resolver.go 96.6% 94.3% -2.3

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/default.go 91.9% 86.6% -5.4
pkg/reconciler/resolutionrequest/controller.go 85.7% 90.9% 5.2
pkg/reconciler/resolutionrequest/resolutionrequest.go 80.0% 81.2% 1.2
pkg/resolution/resolver/bundle/resolver.go 96.6% 94.3% -2.3

@jkhelil jkhelil changed the title make the maximum resolution timeout configurable resolvers maximum resolution timeout is configurable Nov 20, 2024
@jkhelil jkhelil changed the title resolvers maximum resolution timeout is configurable Make resolvers' maximum resolution timeout configurable Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@abayer abayer Awaiting requested review from abayer

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. release-note-none Denotes a PR that doesnt merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Git resolver timeout > 1m doesn't work
3 participants
@jkhelil @tekton-robot @vdemeester