Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform matrix results validation on only result ref params #8089

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Perform matrix results validation on only result ref params #8089

merged 1 commit into from
Jul 4, 2024
+127 −0

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Jul 3, 2024 •
edited
Loading

This will add a check to skip the validation of normal params
while doing the validation for matrix task result ref as params

Fixes #8086

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Perform matrix results validation on only result ref params

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 3, 2024
@piyush-garg
Copy link
Contributor Author

/hold

@tekton-robot tekton-robot requested review from abayer and vdemeester July 3, 2024 07:22
@tekton-robot tekton-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2024
@piyush-garg
Copy link
Contributor Author

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 3, 2024
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% 0.0

@piyush-garg
Copy link
Contributor Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2024
@piyush-garg piyush-garg force-pushed the fix_params_Validation branch from f9743f6 to 2c306ce Compare July 3, 2024 19:11
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2024
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% 0.0

@piyush-garg
Copy link
Contributor Author

piyush-garg commented Jul 4, 2024 •
edited
Loading

This bug fix needs to be cherry-picked in previous LTS - 0.53, 0.56 and 0.59
this started happening as regression from 0.53

@piyush-garg
Perform matrix results validation on only result ref params
43a0112 
This will add a check to skip the validation of normal params
while doing the validation for matrix task result ref as params
@piyush-garg piyush-garg force-pushed the fix_params_Validation branch from 2c306ce to 43a0112 Compare July 4, 2024 19:00
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.2% 99.2% 0.0

chitrangpatel
chitrangpatel reviewed Jul 4, 2024
View reviewed changes
Copy link
Contributor

@chitrangpatel chitrangpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
@tekton-robot tekton-robot merged commit 3a1e45a into tektoncd:main Jul 4, 2024
14 checks passed
@piyush-garg
Copy link
Contributor Author

piyush-garg commented Jul 5, 2024 •
edited
Loading

/cherry-pick release-v0.59.x

@tekton-robot
Copy link
Collaborator

@piyush-garg: new pull request created: #8099

In response to this:

/cherry-pick release-v0.59.x
/cherry-pick release-v0.56.x
/cherry-pick release-v0.53.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Jul 5, 2024
Closed
@piyush-garg
Copy link
Contributor Author

/cherry-pick release-v0.56.x

@piyush-garg
Copy link
Contributor Author

/cherry-pick release-v0.53.x

@tekton-robot
Copy link
Collaborator

@piyush-garg: new pull request created: #8100

In response to this:

/cherry-pick release-v0.56.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Jul 5, 2024
Closed
@tekton-robot
Copy link
Collaborator

@piyush-garg: new pull request created: #8101

In response to this:

/cherry-pick release-v0.53.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Jul 5, 2024
Closed
This was referenced Jul 13, 2024
Merged
Merged
Merged
@afrittoli afrittoli mentioned this pull request Jul 25, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chitrangpatel chitrangpatel chitrangpatel left review comments

@vdemeester vdemeester vdemeester approved these changes

@abayer abayer Awaiting requested review from abayer

Assignees

@chitrangpatel chitrangpatel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Controller crashes for certain Pipeline after upgrade
4 participants
@piyush-garg @tekton-robot @vdemeester @chitrangpatel