feat(matrix): Fix matrix param type mismatch problem for ref array result from customrun scenario #8024
Conversation
tekton-robot
added
the
release-note-none
|
|
tekton-robot
added
size/M
|
Hi @hittyt. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hittyt
force-pushed
the
matrix-ref-customrun-results
branch
from
02df4a4 to
68336fc
Compare
|
/kind bug |
|
The following is the coverage report on the affected files.
|
|
/ok-to-test |
tekton-robot
added
ok-to-test
|
The following is the coverage report on the affected files.
|
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| if got := paramValueFromCustomRunResult(tt.args.result); !reflect.DeepEqual(got, tt.want) { |
There was a problem hiding this comment.
We use cmp for comparisons (see here for example)
There was a problem hiding this comment.
Thanks for the feedback! I've updated the comparison to use cmp as per the project's coding conventions. Please take a look at the latest commit.
…sult from customrun scenario Adjust `resolveCustomResultRef` implementation in Tekton to handle array results from CustomRun tasks correctly. This change resolves a type mismatch issue when using array results as matrix parameters, ensuring compatibility and proper functioning in scenarios where previous CustomRun emits array results.
hittyt
force-pushed
the
matrix-ref-customrun-results
branch
from
68336fc to
0b0774c
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
Hi @tektoncd/core-maintainer, When you get a chance, could you please review this PR? It has already received positive reviews from @vdemeester and is awaiting your We would greatly appreciate a review at your earliest convenience to facilitate progress. I believe the PR is fully compliant with the project's contribution guidelines and is ready for merge. Thank you for your attention to this matter and for your continued work on this project. |
|
/lgtm |
fix #8022
Changes
Adjust
resolveCustomResultRefimplementation in Tekton to handle array results from CustomRun tasks correctly. This change resolves a type mismatch issue when using array results as matrix parameters, ensuring compatibility and proper functioning in scenarios where previous CustomRun emits array results.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes