Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reason of PipelineRun status for PipelineRun having tasks timeout #7744

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix reason of PipelineRun status for PipelineRun having tasks timeout #7744

wants to merge 1 commit into from

Conversation

pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Mar 7, 2024 •
edited
Loading

This patch fixes to set the reason of PipelineRun
status to PipelineRunTimeout if the tasks of a PipelineRun
timeout because of the timeout.tasks parameter

Fixes: #7573

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

 Set the reason of PipelineRun status to PipelineRunTimeout if the tasks of a PipelineRun is timeout

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Mar 7, 2024
@tekton-robot tekton-robot requested review from bobcatfish and jerop March 7, 2024 17:36
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 7, 2024
@pratap0007 pratap0007 force-pushed the fix-pipelinerun-timeout branch from 352db1a to 4070c54 Compare March 7, 2024 17:41
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 99.6% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 99.6% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 99.6% 0.0

@JeromeJu JeromeJu self-assigned this Mar 19, 2024
JeromeJu
JeromeJu reviewed Mar 19, 2024
View reviewed changes
Copy link
Member

@JeromeJu JeromeJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!
I think we would want a release note since this is essentially a user-facing bug fix for the condition.Reason

pkg/reconciler/pipelinerun/resources/pipelinerunstate.go Outdated Show resolved Hide resolved
@pratap0007 pratap0007 force-pushed the fix-pipelinerun-timeout branch from 4070c54 to 09a5d7b Compare April 5, 2024 05:32
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.6% 99.6% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.6% 99.6% 0.0

khrm
khrm reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug

@tekton-robot tekton-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Apr 5, 2024
khrm
khrm reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to fix the starttime in unit tests. That might fix some of the errors.

@JeromeJu
Copy link
Member

Hi @pratap0007 are you actively working on this or shall we update the test results and close this one?

@pratap0007
Copy link
Contributor Author

Hi @pratap0007 are you actively working on this or shall we update the test results and close this one?

Hi @JeromeJu, I am looking to fix the test soon

@pratap0007 pratap0007 force-pushed the fix-pipelinerun-timeout branch from 09a5d7b to b0f6040 Compare April 16, 2024 07:32
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.6% 99.6% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.6% 99.6% 0.0

@vdemeester
Copy link
Member

/retest

@pratap0007 pratap0007 force-pushed the fix-pipelinerun-timeout branch from b0f6040 to ffe7b97 Compare June 18, 2024 04:36
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.6% 99.6% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.6% 99.6% 0.0

@vdemeester
Copy link
Member

/retest

@chitrangpatel
Copy link
Contributor

@pritidesai I think this was last worked on in April so until someone picks it up again, I think we can remove it from the milestones.

@pratap0007 please let us know otherwise.

@chitrangpatel chitrangpatel removed this from the Pipeline v0.62 milestone Jul 17, 2024
@pratap0007 pratap0007 force-pushed the fix-pipelinerun-timeout branch from ffe7b97 to 778688d Compare August 5, 2024 06:07
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.6% 99.6% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.6% 99.6% 0.0

@pratap0007 pratap0007 force-pushed the fix-pipelinerun-timeout branch from 778688d to 69962be Compare November 21, 2024 11:51
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 98.1% 98.2% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 98.1% 98.2% 0.0

@pratap0007
Fix reason of PipelineRun status for PipelineRun having tasks timeout
53888a9 
This patch fixes to set the reason of PipelineRun
status to PipelineRunTimeout if the tasks of a PipelineRun
timeout because of the timeout.tasks parameter

Signed-off-by: Shiv Verma <[email protected]>
@pratap0007 pratap0007 force-pushed the fix-pipelinerun-timeout branch from 69962be to 53888a9 Compare November 21, 2024 13:54
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 98.1% 98.2% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 98.1% 98.2% 0.0

@pratap0007
Copy link
Contributor Author

Hi @khrm @chitrangpatel, could you please take a look

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeromeJu JeromeJu JeromeJu left review comments

@khrm khrm khrm left review comments

@vdemeester vdemeester vdemeester approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@jerop jerop Awaiting requested review from jerop

Assignees

@JeromeJu JeromeJu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

if timeout.tasks is reached pipeline status.reason should be PipelineRunTimeout
7 participants
@pratap0007 @tekton-robot @JeromeJu @vdemeester @chitrangpatel @khrm @afrittoli