Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce warnings caused by woke scan results #7558

Merged
merged 3 commits into from
Feb 26, 2024
Merged

fix: reduce warnings caused by woke scan results #7558

merged 3 commits into from
Feb 26, 2024

Conversation

katmutua
Copy link
Contributor

@katmutua katmutua commented Jan 10, 2024 •
edited
Loading

Changes

The current configuration on the .wokeignore file has an increasing number of warnings and some of the warnings cannot be immediately or directly resolved. These include link references to other repositories. In order to minimize noise caused by the woke scan results; a few additions are being suggested. Annotations have also been added to a few src files that still need to be scanned to suppress a few warnings.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

/kind misc

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 10, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 10, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@tekton-robot
Copy link
Collaborator

Hi @katmutua. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2024
@katmutua katmutua changed the title [fix-suggestion] reduce warnings caused by woke scan results fix: reduce warnings caused by woke scan results Jan 11, 2024
@katmutua
Copy link
Contributor Author

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jan 11, 2024
@katmutua katmutua marked this pull request as ready for review January 11, 2024 03:20
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 11, 2024
@katmutua
Copy link
Contributor Author

/assign @imjasonh

vdemeester
vdemeester approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 11, 2024
@katmutua
Copy link
Contributor Author

/retest

@katmutua katmutua force-pushed the fix-and-update-woke-ignore-list branch 2 times, most recently from f3f254e to a8f2c62 Compare January 11, 2024 19:09
@katmutua
add an ignore annotation on fix failures in scanned files and update …
2abd327 
….wokeignore

The current configuration on the `.wokeignore` file has an increasing number of
warnings and some of the warnings cannot be immediately or directly resolved.
These include link references to other repositories. In order to minimize
noise caused by the woke scan results; a few additions are being suggested.
Annotations have also been added to a few src files that still need to be scanned
to suppress the warnings.

`# Please enter the commit message for your changes. Lines starting
@katmutua
remove annotations added as changes to ignore list already cover thes…
c792a10 
…e files

The .wokeignore file has been modified to ignore these paths the annotations on the source file have been ommitted
@katmutua
add docs/pipeline-api.md to ignore list
92429cb 
This file is a generated file so adding it to the .wokeignore list.
@katmutua katmutua force-pushed the fix-and-update-woke-ignore-list branch from ed6c730 to 92429cb Compare January 30, 2024 22:53
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester
Copy link
Member

cc @JeromeJu @chitrangpatel @dibyom

afrittoli
afrittoli reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2024
@afrittoli
Copy link
Member

/test pull-tekton-pipeline-unit-tests

@tekton-robot tekton-robot merged commit d27e6cf into tektoncd:main Feb 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@vdemeester vdemeester vdemeester approved these changes

@pritidesai pritidesai Awaiting requested review from pritidesai

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@imjasonh imjasonh

@afrittoli afrittoli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@katmutua @tekton-robot @vdemeester @afrittoli @imjasonh