allow pipeline runs whose task/custom runs have been deleted still timeout

[gabemontero]

Fixes #7556

Changes

Back with PR 5134 Tekton started using the cancel function for cleaning up underlying TaskRuns of PipelineRuns that are timing out, though separate timeout functions were used (presumably in case the timeout behavior needed to be tweaked from the cancel behavior later on). Then, in PR 5288, improvements to the baseline cancel function were made to still complete cancel processing of a PipelineRun if the underlying TaskRuns were deleted. However, that same accomodation was not made for the timeout path. This change addresses that, but still keeps the timeout codepaths separate from the 'base' cancel codepaths.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• [n/a ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• [/ ] Has Tests included if any functionality added or changed
• [ /] Follows the commit message standard
• [ /] Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• [/ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• [n/a ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

PipelineRuns that timeout will no longer be blocked on reaching a terminal, cancelled state if their underlying TaskRuns or CustomRuns were deleted beforehand.

@vdemeester @afrittoli @abayer PTAL - thanks

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/timeout.go	87.9%	89.7%	1.9

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/timeout.go	87.9%	89.7%	1.9

[gabemontero]

/kind bug

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/timeout.go	87.9%	89.7%	1.9

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/timeout.go	87.9%	89.7%	1.9

[gabemontero]

/assign @vdemeester
/assign @khrm

[tekton-robot]

@gabemontero: GitHub didn't allow me to assign the following users: khrm.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @vdemeester
/assign @khrm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gabemontero]

/assign @abayer
/assign @afrittoli

[khrm]

/approve
Please review and give lgtm here.
@afrittoli

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/timeout.go	87.9%	89.7%	1.9

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/timeout.go	87.9%	89.7%	1.9

[gabemontero]

rebase completed @khrm @vdemeester @afrittoli and CI clean .... PTAL

[afrittoli]

Thanks!
/lgtm

[vdemeester]

/cherry-pick release-v0.56.x

[tekton-robot]

@vdemeester: #7557 failed to apply on top of branch "release-v0.56.x":

Applying: allow pipeline runs whose task/custom runs have been deleted still timeout
Using index info to reconstruct a base tree...
M	pkg/reconciler/pipelinerun/timeout.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/reconciler/pipelinerun/timeout.go
CONFLICT (content): Merge conflict in pkg/reconciler/pipelinerun/timeout.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 allow pipeline runs whose task/custom runs have been deleted still timeout
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v0.56.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.