Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEP-0094] Feedback/beta release for taskRun.spec.stepSpecs and taskRun.spec.sidecarSpecs #5489

Closed
lbernick opened this issue Sep 13, 2022 · 17 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@lbernick
Copy link
Member

This issue tracks bringing step and sidecar overrides to beta, and any feedback on or issues with this feature.

We'll be renaming these fields to stepSpecs and sidecarSpecs in v1 and can optionally do so as well if/when we enable this feature in v1beta1 without enable-api-fields set to alpha.

@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 12, 2022
@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 11, 2023
@skaegi
Copy link
Contributor

skaegi commented Jan 30, 2023

If we can change the names here can we just use steps and sidecars. The Specs or Overrides word does not add anything and really is not making things less confusing about what you can and can't do.

@lbernick
Copy link
Member Author

@skaegi This feature was actually renamed to stepSpecs and sidecarSpecs in the v1 API (https://github.com/tektoncd/community/blob/main/teps/0096-pipelines-v1.md#api-changes) for consistency with taskRunSpecs in PipelineRun

@skaegi
Copy link
Contributor

skaegi commented Jan 30, 2023

I fully understand... wish that was just taskRuns too but admit the ship has sailed there. With that said I definitely think that Specs is better than Overrides and indeed more consistent.

@lbernick lbernick changed the title Feedback/beta release for StepOverrides and SidecarOverrides Feedback/beta release for taskRun.spec.stepSpecs and taskRun.spec.sidecarSpecs Feb 6, 2023
@tekton-robot
Copy link
Collaborator

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Collaborator

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-project-automation github-project-automation bot moved this from Todo to Done in Tekton Community Roadmap Mar 8, 2023
@lbernick lbernick reopened this Mar 8, 2023
@github-project-automation github-project-automation bot moved this from Done to In Progress in Tekton Community Roadmap Mar 8, 2023
@lbernick lbernick removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 8, 2023
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 6, 2023
@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 6, 2023
@jimmyjones2
Copy link
Contributor

@lbernick Think this is still an issue, can you remove lifecycle/rotten please?

@vdemeester
Copy link
Member

/lifecycle frozen

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jul 7, 2023
@lbernick lbernick changed the title Feedback/beta release for taskRun.spec.stepSpecs and taskRun.spec.sidecarSpecs [TEP-0094] Feedback/beta release for taskRun.spec.stepSpecs and taskRun.spec.sidecarSpecs Aug 2, 2023
@afrittoli afrittoli added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 13, 2023
@khrm
Copy link
Contributor

khrm commented May 29, 2024

/assign @khrm

@khrm
Copy link
Contributor

khrm commented May 29, 2024

Let's add this to the milestone for v0.61.0 @chitrangpatel @vdemeester

PS: I wrongly pinged you guys on some other issue.

@vdemeester vdemeester added this to the Pipeline v0.61 milestone Jun 3, 2024
@chitrangpatel
Copy link
Contributor

@khrm can we move this to the next milestone?

@chitrangpatel
Copy link
Contributor

Removing a milestone from this issue. I think we can assign it as soon as it is picked up again.

@chitrangpatel chitrangpatel removed this from the Pipeline v0.62 milestone Jul 17, 2024
@khrm
Copy link
Contributor

khrm commented Jul 22, 2024

@chitrangpatel This was already merged. So we can close this. #8006
/close

@khrm
Copy link
Contributor

khrm commented Jul 22, 2024

/close

@github-project-automation github-project-automation bot moved this from In Progress to Done in Tekton Community Roadmap Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Done
Development

No branches or pull requests

8 participants