-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC - Remove debug
dependency from production
#840
Comments
The beauty of using the debug library is that you can switch it on and off via EV/app setting, and as it's likely shared across various other dependencies in the Node ecosystem, you can tweak visibility of messages to the library. So I'm in favour of the reporter function that's configurable but would like to see debug remain as a default should none be configured. |
Debug is useful for troubleshooting MSSQL connectivity problems in a production environment. ( |
The idea wouldn't be to remove calls to a logger, but more for that to be a logger that can be defined by the consumer rather than by this library. |
We currently have
debug
as a prod dependency as calls to it are scattered through our code. This isn't great.We should have a reporter function we call that the consumer can hook into, this could be
debug
or it could be any other kind of logger.The text was updated successfully, but these errors were encountered: