-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce support for upgrading dependencies; Change mbedtls_url
to the Github source; Make Shadowsocks-libev
be the preferred option
#119
base: master
Are you sure you want to change the base?
Conversation
在随后的提交中,我将提出一个在我看来更好的策略处理这个问题。 并不是非要坚持用我的办法来解决问题,关键在于这一提交和后来的多个提交都产生了严重的冲突,解决冲突实在太花时间花精力了。 This reverts commit 1e25c70.
@teddysun 嗨,等你有空的时候可以麻烦给点建议或者合并 PR 吗? |
PR 里一次有太多更改,并不方便 review 另,
|
use `[[ … ]]` rather than `[ … ]` (refer: google.github.io/styleguide/shellguide.html#s6.3-tests)
Upgrading dependencies while reinstalling(which is actually means upgrading) shadowsocks.
0. Change `mbedtls_url` to the Github source 1. fix SC2181 2. Also comes with some minor fix
…ry limited memory In case someone is trying to install shadowsocks on a machine with very limited memory
我非常同意你说的这一点。抱歉,这个提交应该是重新开 PR 前你要求我不要将
总之现在我已经把造成问题的提交大卸八块,拆成了 |
GitHub 上的 release 已经很久没发布更新了,参考官方文档,推荐的两种获取源代码的方式分别为以下途径(都是可以被认为稳定的代码):
我研究过,GitHub 的 stable 分支和 https://download.libsodium.org/libsodium/releases/LATEST.tar.gz 地址下载下来的内容都包含同样的提交。所以从 download.libsodium.org 改为 GitHub 源没有问题,但是改成从 releases 里下载最后发布还是 2018 年的 assets 就不是很推荐了。 综上,我还是不能理解为何你希望 libsodium 的源 这块我想我只有和你进一步讨论过后才能得到结论该怎么处理了。 |
是的,我同意你的看法。关于名字为什么这么长,其实是我为下一个提交提前预留的避免混淆的措施。 也许我这个是杞人忧天吧,不知道您是否有些好的起名建议呢?我可以修改成您建议的函数名。
已经 drop 掉相关修改。 |
@teddysun ping... |
ping... @teddysun |
@teddysun ping... |
why there is cryptocurrency code showing up during the installation? is the code compromised? our server company already gave us a warning that cryptocurrency mining is not allowed. the crypto code shows up after below commands: |
You are supposed to ask questions by opening an issue, not reply in a PR, loon. |
0.1. Upgrading dependencies while reinstalling(which is actually means upgrading) shadowsocks.
Shadowsocks-libev
be the preferred option.mbedtls_url
to the Github source.2.1. Adapt for archive structures from GitHub source.