-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OS X compatibility #1
Comments
Oh! And: step 8 (removing old deploys) fails for me, again on OS X. I just get:
(eg. the regex doesn't bring back the filename of my deploy) |
@mattandrews Thanks for the awesome feedback! I've been super busy the past month but will setup a Mac OS X installation to hopefully test this. I primarily test on Windows and Linux (Vagrant) but the goal would be to make this cross OS compatible. I do want to also make this as stable as possible as I notice that the integrated code deploy solutions within Codeship or Codedeploy often break as the AWS and AWS CLI continously upgrade at a faster pace ... So I want to keep this one more inline with current revisions and able to integrate seamlessly with hosted CI. |
@mattandrews Better late then never ... just got around to looking at this. I had some time to add a couple new features (pre-packaged bundle deploy) and made sure points 3 and 4 are fixed. Looking into the top ones but I need to spin up a mac-OS system so I can test. Will get around to these eventually .. if you do have a patch that works cross platform feel free to send that over in a PR. |
Great script! Step 6: Checking Application Source |
+1 to this, I modified the script in my local npm repo to avoid this. For the rest you can brew install greadlink via:
Then you can update the file ~line 322:
I did it in my nvm path for the install EX:
|
Hi – thanks for your great script.
I've been using this on my Mac and ran into a few issues:
readlink -f
fails with an error (the-f
flag doesn't exist) – I got around this by runningbrew install coreutils
and changingreadlink
togreadlink
.sed -r
fails for presumably similar reasons. Again,brew install gnu-sed
then replacing it withgsed -r
worked.~/.aws/credentials
(which I think the AWS CLI docs recommend) but this script errors when looking for them in~/.aws/config
, so I changed those paths.zip
because I forgot to setAWS_CODE_DEPLOY_S3_FILENAME
– the other "required" variables cause the script to throw an error if they're not set, so maybe this one should too?Hope this helps! Probably not worth me patching anything as these changes will likely break the app for non-OSX *nixes, but maybe worth noting somewhere in the readme?
The text was updated successfully, but these errors were encountered: