You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in the current implementation only the signals that are part of a message are set. The unused bits are not set. Which makes sense because there are not used.
But when using this codegen for SAE J1939 CAN messages this doesn't work. Because unused bits should be set to 1 according to this standard.
wallem89
changed the title
Have an option to set all unused bits when creating a new instance of a CAN message for SAE J1939 support
Support option to set all unused bits to 1 when creating a new instance of a CAN message
Nov 6, 2024
in the current implementation only the signals that are part of a message are set. The unused bits are not set. Which makes sense because there are not used.
But when using this codegen for SAE J1939 CAN messages this doesn't work. Because unused bits should be set to 1 according to this standard.
When looking at
cantools
for Python an optionpadding
can be used during encoding of a messages. See:https://cantools.readthedocs.io/en/latest/#cantools.database.can.Database.encode_message
My proposal is that padding will be an optional argument for the new function which is default false.
The text was updated successfully, but these errors were encountered: