-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to k3s Uninstall Script #108
Comments
I can tackle this change if you like. I've already made the necessary changes, but before creating a PR I'd like to discuss them with you. First off, regarding the uninstall scripts. They call /usr/local/bin/k3s-killall.sh which stops the service and kills all processes, and then unmount and remove all files, including the uninstall scripts themselves. Basically this means, checking for it's existence is a safe way of assuming if the system is clean or not. Any error in their execution would prevent said scripts from being removed. The question I have is: Personally I would suggest switching to the script from get.k3s.io:
Looking forward to your/any feedback. |
@timothystewart6 Here's rendered scripts for each, taken from https://github.com/k3s-io/k3s/blob/master/install.sh
|
We mange our own way of cleaning up nodes, however we should rely on k3s's uninstall script that is placed there when k3s is installed.
https://rancher.com/docs/k3s/latest/en/installation/uninstall/
server nodes
/usr/local/bin/k3s-uninstall.sh
agent nodes
/usr/local/bin/k3s-agent-uninstall.sh
We will also want to be sure we can run this multiple times without failure (part of the reason it was extracted from this).
I think we can check to see if it exists first before running and assume if it does not that it's a clean system. Not the best but open to ideas.
The text was updated successfully, but these errors were encountered: