Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements: Attributes, Readme, Code-Documentation #29

Open
anianweber opened this issue Mar 21, 2022 · 1 comment
Open

Improvements: Attributes, Readme, Code-Documentation #29

anianweber opened this issue Mar 21, 2022 · 1 comment

Comments

@anianweber
Copy link
Member

  • Refactor the usage of attribute vs. the usage of classes in the InlineStyleEditing.js und BlockStyleEditing.js code to get a clear distinction of the 2 implementations

  • Improve Readme to further clarify the use case of setting classes vs. the use case of setting other attributes

  • Add additional inline documentation to the code to further clarify whats happening (especially considering the complex API of CkEditor 5)

@mhsdesign
Copy link
Contributor

mhsdesign commented Aug 14, 2022

i can aggree with that :P Code doesnt read that well, when i looked at it the first time ^^

I may be able to help

edit: #32 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants