You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the comments on the announcement post, Shaun Harding brought up the point that it's a bit counter intuitive to use an exception to tell the runner not to create an async task:
If you're going to throw an exception, and go through the trouble of catching it, don't ignore it...
He followed up with another good point:
The intent may not be to catch errors, but should an exception get thrown due to an error, it will be caught and promptly ignored. If you're only looking to catch a very specific type of exception, then a specific type of exception should be defined. If you really must catch all exceptions, then logging the exception would be nice. There's no xdebug.scream to undo that suppression.
Let's use this issue thread to discuss the merits of the approaches he's suggesting:
Use a custom Exception child class, or
Add some sort of logging to the process that will log the exceptions that occur
We could even use both together to allow the logger to differentiate between different types of exceptions but still catch all types.
The text was updated successfully, but these errors were encountered:
In the comments on the announcement post, Shaun Harding brought up the point that it's a bit counter intuitive to use an exception to tell the runner not to create an async task:
He followed up with another good point:
Let's use this issue thread to discuss the merits of the approaches he's suggesting:
We could even use both together to allow the logger to differentiate between different types of exceptions but still catch all types.
The text was updated successfully, but these errors were encountered: