Redefine (array) converting populator configuration #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This redefines the
property
configuration node of #53, because I don't think this config was good UX.With the
poulator
typeConvertingPopulator
everything is fine, here it is the same as with theconverter.<name>.properties
config (<target property name>
=><source property name>
, i.e. user-defined key with user-defined value).With the
poulator
typeArrayConvertingPopulator
, however, a specific key with a user-defined value could be added (itemProperty
=><custom value>
). So suddenly two different types of configuration are mixed here, and I don't think we should do that.My suggestion for the
poulator
typeArrayConvertingPopulator
is therefore that the value can again be anarray
(which also corresponds to the config we defined in #54). It would then look like this:Before (as defined in #53):
Now:
The following is still allowed:
And likewise:
As well as (source and target with same name):
And (also source and target with same name):
Since the use of other populators (apart from
ConvertingPopulator
andArrayConvertingPopulator
) was not supported anyway, I also limited the config to these two types.