Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: log ice events #363

Merged
merged 1 commit into from
Jun 18, 2024
Merged

feat: log ice events #363

merged 1 commit into from
Jun 18, 2024

Conversation

farhat-ha
Copy link
Collaborator

XXXX-YYY

Describe your changes
Log icegatheringstatechange and iceconnectionstatechange events.

📝 To Do

  • All linters pass
  • All tests pass
  • Change documentation based on my changes

✋ Manual testing

  1. Provide manual testing instructions

🦊 Browser testing

Desktop

  • Edge (latest)
  • Chrome
  • Firefox
  • Safari

📸 Screenshots

Description Screenshot
Desktop
usage.gif

@farhat-ha farhat-ha self-assigned this Jun 14, 2024
@farhat-ha farhat-ha merged commit f591bcb into main Jun 18, 2024
2 checks passed
@farhat-ha farhat-ha deleted the haythem/ice_events_log branch June 18, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-telnyx jonathan-telnyx jonathan-telnyx approved these changes

@DeividVeloso DeividVeloso Awaiting requested review from DeividVeloso DeividVeloso is a code owner automatically assigned from team-telnyx/frontend

@ericaprieto ericaprieto Awaiting requested review from ericaprieto ericaprieto is a code owner automatically assigned from team-telnyx/frontend

@priscillasantana priscillasantana Awaiting requested review from priscillasantana priscillasantana is a code owner automatically assigned from team-telnyx/frontend

Assignees

@farhat-ha farhat-ha

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farhat-ha @jonathan-telnyx